-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update internal packages to Python 3.11 #52664
Conversation
- Update Python version from 3.10 to 3.11 in all internal packages - Update python_versions in airbyte_ci configuration - Preserve specific version constraints where applicable Co-Authored-By: [email protected] <[email protected]>
🤖 Devin AI EngineerOriginal prompt from [email protected]:
I'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Devin is currently unreachable - the session may have died. |
@@ -19,7 +19,9 @@ jobs: | |||
if: steps.changed-files.outputs.any_changed == 'true' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@devin-ai-integration you should also update the "Setup Python 3.10" to 3.11
…1 compatibility Co-Authored-By: [email protected] <[email protected]>
@@ -32,8 +32,8 @@ requests-mock = "~=1.9.3" | |||
pytest-mock = "~=3.6.1" | |||
pendulum = "*" | |||
pytest-cov = "~=3.0.0" | |||
hypothesis = "*" | |||
hypothesis-jsonschema = "*" | |||
hypothesis = "~=6.84.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you pin with ^6.84.3
, and leave a comment for why it's important?
Co-Authored-By: [email protected] <[email protected]>
…h versions Co-Authored-By: [email protected] <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, OVERALL this looks good to me. I expect to see a couple of packages failing known bad tests here, but overall I will try and push this in if the CI is happy, and will communicate this widely so we know what to revert if shit hits the fan.
token: ${{ inputs.github_token }} | ||
cache: "pip" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if these are strictly necessary here — but I don't mind? /shrug
@@ -50,6 +50,9 @@ have been merged. | |||
|
|||
## Changelog | |||
|
|||
### 0.1.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lol good catch — we have 0.1.4 out without the changelog entry.
Do not merge this without me, I will look into the failures myself localy. |
/format-fix
|
This reverts commit 5d78a3a.
/format-fix
|
Alright, I expect that the only failing test should be the |
This reverts commit e743cd4.
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: [email protected] <[email protected]> Co-authored-by: Natik Gadzhi <[email protected]> Co-authored-by: Octavia Squidington III <[email protected]>
Description
Updates all internal Python packages to use Python 3.11 and replaces deprecated distutils usage.
Changes
Updated Packages
Link to Devin run
https://app.devin.ai/sessions/7b158d1965bd493db84ea04078974ce6
Pre-merge checklist