Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update internal packages to Python 3.11 #52664

Merged
merged 25 commits into from
Jan 31, 2025

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Jan 30, 2025

Description

Updates all internal Python packages to use Python 3.11 and replaces deprecated distutils usage.

Changes

  • Update Python version from 3.10 to 3.11 in all internal packages' pyproject.toml files
  • Update python_versions in airbyte_ci configuration sections
  • Replace distutils.util.strtobool with custom implementation in airbyte-python-cdk
  • Preserve specific version constraints (e.g., <3.12) where applicable

Updated Packages

  • connector_ops
  • connectors_qa
  • ci_credentials
  • metadata_service/lib
  • metadata_service/orchestrator
  • pipelines
  • common_utils
  • connectors_insights
  • auto_merge
  • erd
  • live-tests
  • connector-acceptance-test

Link to Devin run

https://app.devin.ai/sessions/7b158d1965bd493db84ea04078974ce6

Pre-merge checklist

  • All Python versions updated to 3.11 in pyproject.toml files
  • All airbyte_ci configurations updated to use Python 3.11
  • Specific version constraints preserved where needed
  • distutils.util.strtobool replaced with custom implementation

- Update Python version from 3.10 to 3.11 in all internal packages
- Update python_versions in airbyte_ci configuration
- Preserve specific version constraints where applicable

Co-Authored-By: [email protected] <[email protected]>
@devin-ai-integration devin-ai-integration bot requested review from a team and aaronsteers January 30, 2025 20:07
Copy link
Contributor Author

devin-ai-integration bot commented Jan 30, 2025

🤖 Devin AI Engineer

Original prompt from [email protected]:

@Devin can you make a PR to make a new major version of our Python connector base-image, 4.0, based on Python 3.11 instead of 3.10? AND a separate pull request that would switch all our internal packages (think airbyte-ci) to use python 3.11 in their pyproject.toml files, and in testing harnesses, and make sure the dagger testing containers come with python 3.11 as well.

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Copy link

vercel bot commented Jan 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 5:53am

Copy link
Contributor Author

Devin is currently unreachable - the session may have died.

@@ -19,7 +19,9 @@ jobs:
if: steps.changed-files.outputs.any_changed == 'true'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devin-ai-integration you should also update the "Setup Python 3.10" to 3.11

@@ -32,8 +32,8 @@ requests-mock = "~=1.9.3"
pytest-mock = "~=3.6.1"
pendulum = "*"
pytest-cov = "~=3.0.0"
hypothesis = "*"
hypothesis-jsonschema = "*"
hypothesis = "~=6.84.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you pin with ^6.84.3, and leave a comment for why it's important?

Copy link
Contributor

@natikgadzhi natikgadzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, OVERALL this looks good to me. I expect to see a couple of packages failing known bad tests here, but overall I will try and push this in if the CI is happy, and will communicate this widely so we know what to revert if shit hits the fan.

token: ${{ inputs.github_token }}
cache: "pip"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if these are strictly necessary here — but I don't mind? /shrug

@@ -50,6 +50,9 @@ have been merged.

## Changelog

### 0.1.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol good catch — we have 0.1.4 out without the changelog entry.

@natikgadzhi
Copy link
Contributor

Do not merge this without me, I will look into the failures myself localy. ci_credentials is expected, but the other two, I'd like to fix up

@natikgadzhi
Copy link
Contributor

natikgadzhi commented Jan 31, 2025

/format-fix

Format-fix job started... Check job output.

🟦 Job completed successfully (no changes).

@natikgadzhi
Copy link
Contributor

natikgadzhi commented Jan 31, 2025

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (7b33ba2)

@natikgadzhi
Copy link
Contributor

Alright, I expect that the only failing test should be the ci_credentials one, and if that's true, I will merge this in the morning.

@natikgadzhi natikgadzhi merged commit e743cd4 into master Jan 31, 2025
38 of 40 checks passed
@natikgadzhi natikgadzhi deleted the devin/1738267380-py311-internal branch January 31, 2025 17:55
natikgadzhi added a commit that referenced this pull request Jan 31, 2025
@natikgadzhi natikgadzhi restored the devin/1738267380-py311-internal branch January 31, 2025 19:54
karolur pushed a commit to karolur/airbyte that referenced this pull request Feb 3, 2025
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: [email protected] <[email protected]>
Co-authored-by: Natik Gadzhi <[email protected]>
Co-authored-by: Octavia Squidington III <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants