Bulk load CDK: DestinationRecord has full DestinationStream #55811
+141
−151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
edgao
changed the title
frifriSF59
reviewed
Mar 18, 2025
...ke/src/main/kotlin/io/airbyte/integrations/destination/s3_data_lake/S3DataLakePartitioner.kt
Outdated
Show resolved
Hide resolved
frifriSF59
approved these changes
Mar 18, 2025
| ?: run { | ||
| return abs(random.nextInt()) % numParts | ||
| } | ||
| return abs(primaryKeyValues.hashCode()) % numParts |
There was a problem hiding this comment.
Can we use Math.floorMod for this and skip the MIN_VALUE check?
johnny-schmidt
approved these changes
Mar 18, 2025
frifriSF59
approved these changes
Mar 19, 2025
Valgard
pushed a commit
to mayflower/airbyte
that referenced
this pull request
Mar 25, 2025
…q#55811) Co-authored-by: Francis Genet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pulling this diff out of #55807.
S3DataLakePartitioner has a nontrivial diff; everything else is purely mechanical.
There might be other places where we can do stuff like the partitioner (i.e. instead of storing a map descriptor -> info, get stuff off the stream directly). But I didn't look for them.
(I think we should just leave s3 data lake on local CDK for now :/ since we're about to push some more changes into there anyway)