Change generator to work with new JSDoc-based Type System #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you also update |
oykuyilmaz
reviewed
Dec 29, 2023
README.md
Outdated
| @@ -2,24 +2,6 @@ | |||
|
|
|||
| requires node >= 8 | |||
There was a problem hiding this comment.
is it still this version of node? I had nodejs 14 installed locally but typedoc convert had failed for me with Unexpected token '??=', could you please check the min version again?
There was a problem hiding this comment.
Seems new version of typedoc needs "node": ">= 16", I will change requirements
|
Since we merged ajaxorg/ace#5318, is it possible to take this PR out of draft mode? Or is it still in draft because of other issues? |
Done in ajaxorg/ace#5441 |
InspiredGuy
approved these changes
Jan 2, 2024
oykuyilmaz
approved these changes
Jan 2, 2024
akoreman
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This should allow documentation generator to work with new type system.
Should be merged after - ajaxorg/ace#5318
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.