Skip to content

Initial support for using range.getClientRects to measure text. #5922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nightwing wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Initial support for using range.getClientRects to measure text. #5922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ae1fdc4
WIP: add text width measurement and cursor positioning based on pixel…
mkslanc Jul 24, 2025
a4e3974
text width calculation based on createRange
mkslanc Jul 25, 2025
319f35d
refactor
nightwing Feb 22, 2026
deafc30
test
nightwing Feb 22, 2026
96ccf66
address review comments
nightwing Feb 25, 2026
0120f12
fix most of failing tests
nightwing Mar 23, 2026
eb7d53f
fix rendering of cjk spaces with show invisibles
nightwing Mar 24, 2026
79896d3
fix textinput tests
nightwing Mar 25, 2026
a603e7d
564
nightwing Apr 9, 2026
73d154f
css transform support in mockdom
nightwing Apr 11, 2026
6d7c4cc
support css transform in new measurement method
nightwing Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions demo/kitchen-sink/demo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,6 +673,16 @@ optionsPanelContainer.insertBefore(
"Open Dialog ",
["button", {onclick: openTestDialog.bind(null, false)}, "Scale"],
["button", {onclick: openTestDialog.bind(null, true)}, "Height"]
],
["div", {},
["button", {onclick: function() {
editor.setOption("fontFamily", "cursive");
session.setValue( session.getValue() + "שלום עולם בעברית123" +"\n" + "ジャパン + 八洲\n" + "𒐫𒈙⸻ဪ", 1);
}}, "cursive"],
["button", {onclick: function() {
editor.setOption("fontFamily", "Tahoma");
session.setValue( session.getValue() + "שלום עולם בעברית123" +"\n" + "ジャパン + 八洲", 1);
}}, "Tahoma"],
]
]),
optionsPanelContainer.children[1]
Expand Down
2 changes: 1 addition & 1 deletion demo/kitchen-sink/inline_editor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ require("ace/commands/default_commands").commands.push({
return;
}

var rowCount = 10;
var rowCount = 5.5;
var w = {
row: row,
// rowCount: rowCount,
Expand Down
Loading
Loading