Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(wallet): add functional tests for /blocks and /transactions #825

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jzsfkzm
Copy link
Contributor

@jzsfkzm jzsfkzm commented Feb 10, 2025

refs #719

@jzsfkzm jzsfkzm requested a review from a team as a code owner February 10, 2025 18:20
@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.30%. Comparing base (64202f7) to head (3c11e0e).
Report is 17 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #825       +/-   ##
===========================================
- Coverage   80.87%   11.30%   -69.57%     
===========================================
  Files          12      438      +426     
  Lines         413    11576    +11163     
  Branches       75     2449     +2374     
===========================================
+ Hits          334     1309      +975     
- Misses         79    10092    +10013     
- Partials        0      175      +175     
Flag Coverage Δ
deploy-web 8.72% <ø> (?)
provider-proxy 81.90% <ø> (+1.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jzsfkzm jzsfkzm force-pushed the test/api-functional-tests branch 2 times, most recently from 3c11e0e to dcf5615 Compare February 10, 2025 21:33
@ygrishajev
Copy link
Contributor

I think tests are failing in the CI as CI db doesn't have data. Let's try removing this var

baktun14
baktun14 previously approved these changes Feb 11, 2025
@baktun14
Copy link
Contributor

Yea that's a good point @ygrishajev we should focus on tests that don't require indexer data and that ultimately will need to be refactored in the module architecture. We do have this task that we should resolve before adding more tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants