Align with rh-openjdk/jdk#1 final version #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This attribute isn't queried but used as input, as required in rh-openjdk/jdk@62ffef3 code. However, after rh-openjdk/jdk@f3d97d5, this is no longer needed, since that information is queried by the exporter itself. Referenced commits are part of rh-openjdk/jdk#1.
This way, we can easily add or reorder them
Otherwise, we aren't really testing the FIPSKeyImporter code Sensitive attributes can be found in the following references: https://github.com/rh-openjdk/jdk/blob/1e26894969d911776f60eaa557d25a2b389060da/src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/PKCS11.java#L2126-L2141 https://github.com/nss-dev/nss/blob/NSS_3_67_RTM/lib/softoken/pkcs11u.c#L798-L822
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @akashche, hope you are doing well :)
This PR implements some little improvements to align with the final version of rh-openjdk/jdk#1, and in line with some items discussed in my feedback email. I've made the changes to better test the 11u backport (rh-openjdk/jdk11u#6), so I appreciate the effort invested in this test suite!
Merge this only if you want to keep this repository synced, I'll keep my fork as a backup in case you want to delete it.