Repository navigation
Conversation
Bug: - Both the Scale Bar Tool and the Guidelines Tool were assigned Shift+F8 in CreateActions::createDigitize, and both QActions belong to the same QActionGroup, so one of the two tools could not be reached from the keyboard. The Scale Bar Tool keeps Shift+F8; the Guidelines Tool moves to Shift+F9, which is the next free shortcut in the digitize group (Shift+F2..F8 were taken). The translation files need no update: after this change the Guidelines Tool has a new, untranslated shortcut string that falls back to the source text, while the existing Shift+F8 translation still applies to the Scale Bar Tool. Tested: built and ran with Qt 6.8 (MSVC); Shift+F9 now activates the Guidelines Tool, Shift+F8 still activates the Scale Bar Tool.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug:
The translation files need no update: after this change the Guidelines Tool has a new, untranslated shortcut string that falls back to the source text, while the existing Shift+F8 translation still applies to the Scale Bar Tool.
Tested: built and ran with Qt 6.8 (MSVC); Shift+F9 now activates the Guidelines Tool, Shift+F8 still activates the Scale Bar Tool.