Repository navigation
Conversation
The Segment Fill settings dialog is fully wired up - the QAction is created in CreateActions::createSettings, it is connected to MainWindow::slotSettingsSegments, and the dialog instance is created in CreateSettingsDialogs - but m_actionSettingsSegments is never added to any menu or toolbar, so the dialog cannot be opened at all and the segment fill settings (minimum length, point separation, fill corners, line size, line colour) cannot be changed from the user interface. The action is added to the Settings menu, next to the Point Match entry, as suggested in issue akhuettel#9. The dialog text is unchanged and already translated, so the translation files need no update. Fixes akhuettel#9
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Segment Fill settings dialog is fully wired up - the QAction is created in CreateActions::createSettings, it is connected to
MainWindow::slotSettingsSegments, and the dialog instance is created in CreateSettingsDialogs - but m_actionSettingsSegments is never added to any menu or toolbar, so the dialog cannot be opened at all and the segment fill settings (minimum length, point separation, fill corners, line size, line colour) cannot be changed from the user interface.
The action is added to the Settings menu, next to the Point Match entry, as suggested in issue #9.
The dialog text is unchanged and already translated, so the translation files need no update.
Fixes #9