Skip to content

Conversation

@Aleksanaa
Copy link

These three have the same functionalities as sudo does, so they should be treated equally. For example, currently completion works for commands after sudo but not doas.

I'm not pretty sure if the changes are complete though.

@akinomyoga
Copy link
Owner

These three have the same functionalities as sudo does, so they should be treated equally.

Thanks! Hmm, there seem to be also fakeroot and kdesudo that take admin commands in their arguments just like sudo (and gksu, gksudo, and really seem to be similar deprecated old commands). There are also commands that receive another command, such as timeout and watch. (Some minor commands are aoss, ccache, ionice, ltrace, padsp, strace, tsocks, valgrind, vsound, and xvfb-run, but I'm not sure if it's worth including it. Probably not.). And, most importantly, I seem to have forgot to include else in the list.

Actually the code that this PR changes is used to detect the use of clear or reset to clear the terminal display, but no one would try to use sudo or other administrative commands just to clear the terminal display...

For example, currently completion works for commands after sudo but not doas.

But the suggested change in this PR is unrelated to the completion, so this PR does not solve the problem of completion that you are now facing with. Actually, ble.sh is inresponsible for the completion settings for each command. ble.sh just uses the completion settings set up by users or by another framework such as bash-completion.

The doas completion is actually discussed in bash-completion: scop/bash-completion#505 and scop/bash-completion#766.

@Aleksanaa
Copy link
Author

In that case I'll track the issue there. Sorry to bother!

@Aleksanaa Aleksanaa closed this Feb 20, 2023
@akinomyoga
Copy link
Owner

It seems there are also a discussion in the upstream OpenDoas in Duncaen/OpenDoas#62, and a PR Duncaen/OpenDoas#84.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants