Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ImageManager #334

Merged
merged 24 commits into from
Apr 26, 2020
Merged

Implement ImageManager #334

merged 24 commits into from
Apr 26, 2020

Conversation

Alecaddd
Copy link
Member

@Alecaddd Alecaddd commented Apr 20, 2020 •
edited
Loading

Summary / How this PR fixes the problem?

Implement an ImageManager class to handle conversion of images into base64 and viceversa, validation of supported files, and properly saving the images inside the saved file.

This PR fixes/implements the following bugs/features:

  • Validate images when importing them.
  • Save the image inside the zipped .akira archive.
  • Load images from the zipped .akira archive.
  • Optimize image resolution on resize.
  • Restore the correct order of the saved items.

Fixes #333

@Alecaddd Alecaddd added this to the v1.0 milestone Apr 20, 2020
@Alecaddd Alecaddd mentioned this pull request Apr 24, 2020
Closed
@Alecaddd Alecaddd changed the title [WIP] Implement ImageManager Implement ImageManager Apr 24, 2020
@Alecaddd Alecaddd requested review from giacomoalbe and albfan April 24, 2020 22:07
@Alecaddd Alecaddd marked this pull request as ready for review April 24, 2020 22:07
@Alecaddd Alecaddd requested a review from bilelmoussaoui April 25, 2020 17:28
@Alecaddd Alecaddd merged commit 697c977 into master Apr 26, 2020
@Alecaddd Alecaddd deleted the image-handler branch April 26, 2020 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giacomoalbe giacomoalbe Awaiting requested review from giacomoalbe

@albfan albfan Awaiting requested review from albfan

@bilelmoussaoui bilelmoussaoui Awaiting requested review from bilelmoussaoui

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.0.1
Development

Successfully merging this pull request may close these issues.

Properly handle images
1 participant
@Alecaddd