Skip to content

[Streams] Fix StreamRefSettings.FinalTerminationSignalDeadline never initialized #7834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: v1.5
Choose a base branch
from
Open

[Streams] Fix StreamRefSettings.FinalTerminationSignalDeadline never initialized #7834

wants to merge 6 commits into from

Conversation

Arkatufus
Copy link
Contributor

@Arkatufus Arkatufus commented Sep 18, 2025 •
edited
Loading

The FinalTerminationSignalDeadline property of StreamRefSettings never get initialized from HOCON settings, it is always TimeSpan.Zero.

Changes

  • Make sure FinalTerminationSignalDeadline is initialized.
  • Clean up reference.conf, convert all tabs to spaces

@Aaronontheweb Aaronontheweb added this to the 1.5.50 milestone Sep 18, 2025
@Aaronontheweb Aaronontheweb modified the milestones: 1.5.50, 1.5.51 Sep 22, 2025
@Aaronontheweb Aaronontheweb modified the milestones: 1.5.51, 1.5.52 Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
akka-streams
Projects
None yet
Milestone
1.5.52
Development

Successfully merging this pull request may close these issues.
2 participants
@Arkatufus @Aaronontheweb