Skip to content

fix: concurrency/deadlock issues in histogram, barrier, options and e…#568

Open
wangxp006 wants to merge 1 commit into
akopytov:masterfrom
wangxp006:master
Open

fix: concurrency/deadlock issues in histogram, barrier, options and e…#568
wangxp006 wants to merge 1 commit into
akopytov:masterfrom
wangxp006:master

Conversation

@wangxp006
Copy link
Copy Markdown

…ventgen thread

  • sb_histogram.c: fix missing pthread_rwlock_unlock on early return in sb_histogram_print(), which caused a deadlock when maxcnt == 0
  • sb_barrier.c: fix pthread_mutex leak when pthread_cond_init fails after pthread_mutex_init succeeds
  • sysbench.c: fix pthread_mutex leak in eventgen_thread_proc on the same mutex/cond init pattern
  • sb_options.c: replace non-thread-safe strtok() with strtok_r() for parsing list option values

…ventgen thread

- sb_histogram.c: fix missing pthread_rwlock_unlock on early return in
  sb_histogram_print(), which caused a deadlock when maxcnt == 0
- sb_barrier.c: fix pthread_mutex leak when pthread_cond_init fails after
  pthread_mutex_init succeeds
- sysbench.c: fix pthread_mutex leak in eventgen_thread_proc on the same
  mutex/cond init pattern
- sb_options.c: replace non-thread-safe strtok() with strtok_r() for parsing
  list option values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant