update unit test #14
Open
update unit test #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbcfive
force-pushed
the
update-oauth-unit-test
branch
from
01e9df5 to
2f91dd2
Compare
akshgpt7
requested changes
Dec 13, 2020
There was a problem hiding this comment.
Thanks for the PR, this is really looking good. Just a few general comments:
- Please rename the file to
oauth_test.tsinstead ofoauth.test.ts, since it looks a bit cleaner regarding the file extension. - Try adding a few more test cases like multiple scopes in one scope string, missing the required parameters etc.
- I just pushed a change to fix these linting errors, so make sure you pull that from master.
Also, do you plan to write the tests for the youtube-deno.ts file? If so, would they be in the same PR, or a separate one?
bbcfive
force-pushed
the
update-oauth-unit-test
branch
2 times, most recently
from
475eaf7 to
b2a07b2
Compare
bbcfive
force-pushed
the
update-oauth-unit-test
branch
from
c9edb92 to
3a03590
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.