Feature/s2s graph #3408

ankush-jain-akto · 2025-10-25T17:24:22Z

No description provided.

Copilot

Pull Request Overview

This PR introduces a service-to-service (S2S) graph feature for Kubernetes daemonset deployments, enabling tracking and visualization of service communication patterns through graph nodes and edges.

Key Changes:

Added SvcToSvcGraphManager to process and manage service communication graph data
Integrated graph parameter extraction from HTTP traffic via SampleParser
Created DAO layer and database operations for persisting graph nodes and edges

Reviewed Changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
`SvcToSvcGraphManager.java`	Core manager implementing graph construction logic from traffic data
`SampleParser.java`	Extracts K8s graph parameters from HTTP request headers when enabled
`HttpResponseParams.java`	Added field to carry graph parameters through the processing pipeline
`DataActor.java` / `DbActor.java` / `ClientActor.java`	Implemented abstract methods for graph data persistence
`DbLayer.java`	Database query and update operations for graph edges and nodes
`APICatalogSync.java` (both apps)	Integrated graph manager into traffic processing workflow
`SvcToSvcGraph*.java` (DTOs)	Data models for graph representation
`SvcToSvcGraphEdgesDao.java` / `SvcToSvcGraphNodesDao.java`	MongoDB DAO implementations
`DbAction.java` / `struts.xml`	REST API endpoints for graph data operations
`pom.xml` files	Added Lombok dependency
`TestSvcToSvcGraph.java`	Unit test for graph manager functionality

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-10-25T17:25:27Z

libs/utils/src/main/java/com/akto/data_actor/DbLayer.java

+                Filters.gte(SvcToSvcGraphEdge.CREATTION_EPOCH, startTs),
+                Filters.lte(SvcToSvcGraphEdge.CREATTION_EPOCH, endTs)
+        ), skip, limit, Sorts.ascending(SvcToSvcGraphEdge.CREATTION_EPOCH));
+    }
+
+    public static List<SvcToSvcGraphNode> findSvcToSvcGraphNodes(int startTs, int endTs, int skip, int limit) {
+        return SvcToSvcGraphNodesDao.instance.findAll(Filters.and(
+                Filters.gte(SvcToSvcGraphEdge.CREATTION_EPOCH, startTs),
+                Filters.lte(SvcToSvcGraphEdge.CREATTION_EPOCH, endTs)
+        ), skip, limit, Sorts.ascending(SvcToSvcGraphEdge.CREATTION_EPOCH));


Corrected spelling of 'CREATTION_EPOCH' to 'CREATION_EPOCH'.

Suggested change

Filters.gte(SvcToSvcGraphEdge.CREATTION_EPOCH, startTs),

Filters.lte(SvcToSvcGraphEdge.CREATTION_EPOCH, endTs)

), skip, limit, Sorts.ascending(SvcToSvcGraphEdge.CREATTION_EPOCH));

}

public static List<SvcToSvcGraphNode> findSvcToSvcGraphNodes(int startTs, int endTs, int skip, int limit) {

return SvcToSvcGraphNodesDao.instance.findAll(Filters.and(

Filters.gte(SvcToSvcGraphEdge.CREATTION_EPOCH, startTs),

Filters.lte(SvcToSvcGraphEdge.CREATTION_EPOCH, endTs)

), skip, limit, Sorts.ascending(SvcToSvcGraphEdge.CREATTION_EPOCH));

Filters.gte(SvcToSvcGraphEdge.CREATION_EPOCH, startTs),

Filters.lte(SvcToSvcGraphEdge.CREATION_EPOCH, endTs)

), skip, limit, Sorts.ascending(SvcToSvcGraphEdge.CREATION_EPOCH));

}

public static List<SvcToSvcGraphNode> findSvcToSvcGraphNodes(int startTs, int endTs, int skip, int limit) {

return SvcToSvcGraphNodesDao.instance.findAll(Filters.and(

Filters.gte(SvcToSvcGraphEdge.CREATION_EPOCH, startTs),

Filters.lte(SvcToSvcGraphEdge.CREATION_EPOCH, endTs)

), skip, limit, Sorts.ascending(SvcToSvcGraphEdge.CREATION_EPOCH));

Copilot · 2025-10-25T17:25:27Z

libs/utils/src/main/java/com/akto/data_actor/DbLayer.java

+                Filters.gte(SvcToSvcGraphEdge.CREATTION_EPOCH, startTs),
+                Filters.lte(SvcToSvcGraphEdge.CREATTION_EPOCH, endTs)
+        ), skip, limit, Sorts.ascending(SvcToSvcGraphEdge.CREATTION_EPOCH));


The method findSvcToSvcGraphNodes incorrectly references SvcToSvcGraphEdge.CREATTION_EPOCH instead of SvcToSvcGraphNode.CREATTION_EPOCH (or the corrected constant name). This will cause a compilation error or incorrect filtering as it's querying nodes but using edge field constants.

Suggested change

Filters.gte(SvcToSvcGraphEdge.CREATTION_EPOCH, startTs),

Filters.lte(SvcToSvcGraphEdge.CREATTION_EPOCH, endTs)

), skip, limit, Sorts.ascending(SvcToSvcGraphEdge.CREATTION_EPOCH));

Filters.gte(SvcToSvcGraphNode.CREATTION_EPOCH, startTs),

Filters.lte(SvcToSvcGraphNode.CREATTION_EPOCH, endTs)

), skip, limit, Sorts.ascending(SvcToSvcGraphNode.CREATTION_EPOCH));

Copilot · 2025-10-25T17:25:27Z

libs/dao/src/main/java/com/akto/dto/graph/SvcToSvcGraphEdge.java

+
+    private String target;
+
+    public static final String CREATTION_EPOCH = "creationEpoch";


Corrected spelling of 'CREATTION_EPOCH' to 'CREATION_EPOCH'.

Suggested change

public static final String CREATTION_EPOCH = "creationEpoch";

public static final String CREATION_EPOCH = "creationEpoch";

Copilot · 2025-10-25T17:25:28Z

libs/utils/src/main/java/com/akto/runtime/SvcToSvcGraphManager.java

+        for (String node: newNodes) {
+            boolean isNewNode = addNode(node);
+
+            if (!isNewNode) {
+                continue;
+            }
+
+            newNodes.remove(node);
+
+        }


Modifying newNodes set while iterating over it will cause a ConcurrentModificationException. Use an iterator with remove() or collect nodes to remove in a separate list.

Copilot · 2025-10-25T17:25:28Z

libs/utils/src/main/java/com/akto/data_actor/ClientActor.java

 import com.mongodb.BasicDBList;
 import com.mongodb.BasicDBObject;

+import org.apache.kafka.common.protocol.types.Field.Str;


Unused import statement org.apache.kafka.common.protocol.types.Field.Str should be removed.

Suggested change

import org.apache.kafka.common.protocol.types.Field.Str;

devsecopsbot

🤖 AI Security analysis: "Multiple package vulnerabilities in jackson-databind were detected in the dependency manifest (libs/dao/pom.xml). These CVEs enable unsafe deserialization and JNDI/gadget-based attacks that can lead to remote code execution when processing untrusted JSON. Address dependency and deserialization controls urgently."

Risk Level	AI Score
🟠 HIGH	70.0/100

Top 5 security issues / 126 total (Critical: 0, High: 0, Medium: 126, Low: 0)

Title	Location	Recommendation
CVE-2020-14060: jackson-databind: serialization in oadd.org.apache.xalan.lib.sq…	`libs/dao/pom.xml:1`	libs/dao/pom.xml: com.fasterxml.jackson.core:[email protected]
CVE-2020-14061: jackson-databind: serialization in weblogic/oracle-aqjms	`libs/dao/pom.xml:1`	libs/dao/pom.xml: com.fasterxml.jackson.core:[email protected]
CVE-2020-14062: jackson-databind: serialization in com.sun.org.apache.xalan.int…	`libs/dao/pom.xml:1`	libs/dao/pom.xml: com.fasterxml.jackson.core:[email protected]
CVE-2020-14195: jackson-databind: serialization in org.jsecurity.realm.jndi.Jnd…	`libs/dao/pom.xml:1`	libs/dao/pom.xml: com.fasterxml.jackson.core:[email protected]
CVE-2020-24616: jackson-databind: mishandles the interaction between serializat…	`libs/dao/pom.xml:1`	libs/dao/pom.xml: com.fasterxml.jackson.core:[email protected]

🔗 View Detailed Report

ankush-jain-akto and others added 9 commits April 18, 2025 12:20

add service to service graph

aa4e4a1

Update DbAction.java with all APIs

e04526e

Update struts.xml with graph APIs

a9f7500

use correct name

6ffb893

fix api name and parameter name

5cd061c

fix pom.xml and add test

837e39f

draw graph for non-ip hosts only

4bfb68b

Merge branch 'feature/mini-runtime-release' into feature/s2s_graph

7edf860

Merge branch 'feature/mini-runtime-release' into feature/s2s_graph

5ef18f2

Copilot AI review requested due to automatic review settings October 25, 2025 17:24

Copilot AI reviewed Oct 25, 2025

View reviewed changes

devsecopsbot bot reviewed Oct 25, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feature/s2s graph #3408

Feature/s2s graph #3408

ankush-jain-akto commented Oct 25, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Oct 25, 2025

Uh oh!

Copilot AI Oct 25, 2025

Uh oh!

Copilot AI Oct 25, 2025

Uh oh!

Copilot AI Oct 25, 2025

Uh oh!

Copilot AI Oct 25, 2025

Uh oh!

devsecopsbot bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		private String target;

		public static final String CREATTION_EPOCH = "creationEpoch";

	public static final String CREATTION_EPOCH = "creationEpoch";
	public static final String CREATION_EPOCH = "creationEpoch";

Feature/s2s graph #3408

Are you sure you want to change the base?

Feature/s2s graph #3408

Conversation

ankush-jain-akto commented Oct 25, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 25, 2025

Choose a reason for hiding this comment

Uh oh!

devsecopsbot bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants