Skip to content

Feature/improve custom rotate #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
quhxl wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Feature/improve custom rotate #631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec178bd
feat: improve custom rotate UX with larger previews and float precision
quhxl Apr 3, 2026
0ed5e95
normalize angle inputs to 1 decimal and add finite-value validation
quhxl Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 17 additions & 12 deletions src/js/logic/rotate-custom-page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ function createPageWrapper(

const canvasWrapper = document.createElement('div');
canvasWrapper.className =
'thumbnail-wrapper flex items-center justify-center p-2 h-36';
'thumbnail-wrapper flex items-center justify-center p-2 h-64';
canvasWrapper.style.transition = 'transform 0.3s ease';
// Apply initial rotation if it exists (negated for canvas display)
const initialRotation = pageState.rotations[pageIndex] || 0;
Expand Down Expand Up @@ -115,16 +115,17 @@ function createPageWrapper(
const input = document.getElementById(
`page-angle-${pageIndex}`
) as HTMLInputElement;
const current = parseInt(input.value) || 0;
input.value = (current - 1).toString();
const current = parseFloat(input.value) || 0;
input.value = (Math.round((current - 1) * 10) / 10).toString();
};

const angleInput = document.createElement('input');
angleInput.type = 'number';
angleInput.step = '0.1';
angleInput.id = `page-angle-${pageIndex}`;
angleInput.value = pageState.rotations[pageIndex]?.toString() || '0';
angleInput.className =
'w-12 h-8 text-center bg-gray-700 border border-gray-600 text-white rounded text-xs';
'w-16 h-8 text-center bg-gray-700 border border-gray-600 text-white rounded text-xs';

const incrementBtn = document.createElement('button');
incrementBtn.className =
Expand All @@ -135,8 +136,8 @@ function createPageWrapper(
const input = document.getElementById(
`page-angle-${pageIndex}`
) as HTMLInputElement;
const current = parseInt(input.value) || 0;
input.value = (current + 1).toString();
const current = parseFloat(input.value) || 0;
input.value = (Math.round((current + 1) * 10) / 10).toString();
};

const applyBtn = document.createElement('button');
Expand All @@ -148,7 +149,9 @@ function createPageWrapper(
const input = document.getElementById(
`page-angle-${pageIndex}`
) as HTMLInputElement;
const angle = parseInt(input.value) || 0;
const parsed = parseFloat(input.value);
const angle = Number.isFinite(parsed) ? Math.round(parsed * 10) / 10 : 0;
input.value = angle.toString();
pageState.rotations[pageIndex] = angle;
const wrapper = container.querySelector(
'.thumbnail-wrapper'
Expand Down Expand Up @@ -375,21 +378,23 @@ document.addEventListener('DOMContentLoaded', function () {

if (batchDecrement && batchAngleInput) {
batchDecrement.addEventListener('click', function () {
const current = parseInt(batchAngleInput.value) || 0;
batchAngleInput.value = (current - 1).toString();
const current = parseFloat(batchAngleInput.value) || 0;
batchAngleInput.value = (Math.round((current - 1) * 10) / 10).toString();
});
}

if (batchIncrement && batchAngleInput) {
batchIncrement.addEventListener('click', function () {
const current = parseInt(batchAngleInput.value) || 0;
batchAngleInput.value = (current + 1).toString();
const current = parseFloat(batchAngleInput.value) || 0;
batchAngleInput.value = (Math.round((current + 1) * 10) / 10).toString();
});
}

if (batchApply && batchAngleInput) {
batchApply.addEventListener('click', function () {
const angle = parseInt(batchAngleInput.value) || 0;
const parsed = parseFloat(batchAngleInput.value);
const angle = Number.isFinite(parsed) ? Math.round(parsed * 10) / 10 : 0;
batchAngleInput.value = angle.toString();
for (let i = 0; i < pageState.rotations.length; i++) {
pageState.rotations[i] = angle;
}
Expand Down
3 changes: 2 additions & 1 deletion src/pages/rotate-custom.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@
id="batch-custom-angle"
type="number"
value="0"
step="0.1"
class="w-20 h-10 text-center bg-gray-700 border border-gray-600 text-white rounded-lg"
/>
<button
Expand All @@ -198,7 +199,7 @@
<!-- Page Thumbnails -->
<div
id="page-thumbnails"
class="grid grid-cols-2 sm:grid-cols-3 md:grid-cols-4 lg:grid-cols-5 gap-4 mb-4"
class="grid grid-cols-1 sm:grid-cols-2 md:grid-cols-2 lg:grid-cols-3 gap-6 mb-4"
></div>

<button id="process-btn" class="btn-gradient w-full mt-4">
Expand Down
Loading