feat: enable multiple webhook secrets for APP_WEBHOOK #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamSelene
force-pushed
the
olivier-sambourg/feat-enable-multiple-webhook-secrets-for-APP_WEBHOOK
branch
4 times, most recently
from
3d0b937 to
5e10fdb
Compare
AdamSelene
force-pushed
the
olivier-sambourg/feat-enable-multiple-webhook-secrets-for-APP_WEBHOOK
branch
from
5e10fdb to
abf412a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We can now use multiple Intercom OAuth apps when creating piece credentials, thus accessing multiple workspaces in staging (on production we only need one OAuth app)
But when receiving a webhook event from Intercom, we verify its signature using a secret provided as an env var to ActivePieces - this secret is specific to each intercom OAuth app
This PR makes it possible to pass a map of secrets, indexed by app ID