add RN New Arch Fabric support #9
Conversation
There was a problem hiding this comment.
Thanks @muhamad-rizki for your work on this, it's really appreciated 🙏
Unfortunately, I was not able to make it work on my end in the example app from your branch. When I run the Android app with Fabric enabled with your changes, here is what I get:
Are there specific instructions to follow to build the app with Fabric enabled, other than setting newArchEnabled=true in gradle.properties?
|
|
||
| @ReactModule(name = FastShadowViewManagerImpl.NAME) |
There was a problem hiding this comment.
The only difference between this file and the one in oldarch is this annotation. Is there any way we could use the same file for both archs? Can we use @ReactModule with the non-Fabric arch?
There was a problem hiding this comment.
hi sorry for late response, I just following guide from here (https://github.com/react-native-community/RNNewArchitectureLibraries/tree/feat/back-fabric-comp), I'll look into it to make same file for both archs
I test it with my apps directly instead from example folder with RN version 0.71, I tried to build the example folder with it looks like RN Reanimated only support fabric with RN version 0.70+, I can make it compiled when removing reanimated example. And it looks like RN New Arch Auto linking is supported from RN v0.70+, that's why example apps not worked (https://reactnative.dev/blog/2022/09/05/version-070#android-auto-linking-for-new-architecture-libraries), it need some adjustment on example app (193ab4c) |
| @@ -5,6 +5,10 @@ include $(REACT_ANDROID_DIR)/Android-prebuilt.mk | |||
| # If you wish to add a custom TurboModule or Fabric component in your app you | |||
| # will have to include the following autogenerated makefile. | |||
| # include $(GENERATED_SRC_DIR)/codegen/jni/Android.mk | |||
|
|
|||
| # Includes the MK file for `react-native-fast-shadow` | |||
| include $(NODE_MODULES_DIR)/../../android/build/generated/source/codegen/jni/Android.mk | |||
There was a problem hiding this comment.
it's pointed to android folder directly due to example app folder structure, on end user app it should be something like this $(NODE_MODULES_DIR)/react-native-fast-shadow/android/build/generated/source/codegen/jni/Android.mk
|
is this pull request ready for merge? |
muhamad-rizki
force-pushed
the
feat/fabric-support
branch
from
6e96e59 to
b99aea8
Compare
|
Hi @simontreny |
This pull request implement RN New Architecture Fabric for Android