Apply clang-tidy to codebase

.clang-tidy

@@ -0,0 +1,30 @@
+---
+Checks:          'clang-diagnostic-*,clang-analyzer-*,-clang-analyzer-alpha*,modernize-*,performance-*,readability-*,-readability-braces-around-statements,-readability-named-parameter'
+WarningsAsErrors: ''
+HeaderFilterRegex: '/caf/'
+AnalyzeTemporaryDtors: false
+CheckOptions:
+  - key:             cert-oop11-cpp.UseCERTSemantics
+    value:           '1'
+  - key:             google-readability-braces-around-statements.ShortStatementLines
+    value:           '1'
+  - key:             google-readability-function-size.StatementThreshold
+    value:           '800'
+  - key:             google-readability-namespace-comments.ShortNamespaceLines
+    value:           '10'
+  - key:             google-readability-namespace-comments.SpacesBeforeComments
+    value:           '2'
+  - key:             modernize-loop-convert.MaxCopySize
+    value:           '16'
+  - key:             modernize-loop-convert.MinConfidence
+    value:           reasonable
+  - key:             modernize-loop-convert.NamingStyle
+    value:           CamelCase
+  - key:             modernize-pass-by-value.IncludeStyle
+    value:           llvm
+  - key:             modernize-replace-auto-ptr.IncludeStyle
+    value:           llvm
+  - key:             modernize-use-nullptr.NullMacros
+    value:           'NULL'
+...
+

examples/broker/protobuf_broker.cpp

@@ -137,7 +137,7 @@ void protobuf_io(broker* self, connection_handle hdl, const actor& buddy) {
   self->become(await_length_prefix);
 }
 
-behavior server(broker* self, actor buddy) {
+behavior server(broker* self, const actor& buddy) {
   print_on_exit(self, "server");
   aout(self) << "server is running" << endl;
   return {

examples/curl/curl_fuse.cpp

@@ -1,4 +1,4 @@
-/******************************************************************************\
+/******************************************************************************
  * This example                                                               *
  * - emulates a client launching a request every 10-300ms                     *
  * - uses a CURL-backend consisting of a master and 10 workers                *
@@ -28,12 +28,12 @@
  *          |                                     |<--/                       *
  *          | <-------------(reply)-------------- |                           *
  *          X                                                                 *
-\ ******************************************************************************/
+ ******************************************************************************/
 
 // C includes
-#include <time.h>
-#include <signal.h>
-#include <stdlib.h>
+#include <ctime>
+#include <csignal>
+#include <cstdlib>
 
 // C++ includes
 #include <string>
@@ -129,7 +129,7 @@ struct base_state {
 };
 
 // encapsulates an HTTP request
-behavior client_job(stateful_actor<base_state>* self, actor parent) {
+behavior client_job(stateful_actor<base_state>* self, const actor& parent) {
   if (!self->state.init("client-job", color::blue))
     return {}; // returning an empty behavior terminates the actor
   self->send(parent, read_atom::value,
@@ -164,7 +164,7 @@ struct client_state : base_state {
 };
 
 // spawns HTTP requests
-behavior client(stateful_actor<client_state>* self, actor parent) {
+behavior client(stateful_actor<client_state>* self, const actor& parent) {
   using std::chrono::milliseconds;
   self->link_to(parent);
   if (!self->state.init("client", color::green))
@@ -190,8 +190,8 @@ struct curl_state : base_state {
     // nop
   }
 
-  ~curl_state() {
-    if (curl)
+  ~curl_state() override {
+    if (curl != nullptr)
       curl_easy_cleanup(curl);
   }
 
@@ -206,7 +206,7 @@ struct curl_state : base_state {
 
   bool init(std::string m_name, std::string m_color) override {
     curl = curl_easy_init();
-    if (!curl)
+    if (curl == nullptr)
       return false;
     curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, &curl_state::callback);
     curl_easy_setopt(curl, CURLOPT_NOSIGNAL, 1);
@@ -218,7 +218,7 @@ struct curl_state : base_state {
 };
 
 // manages a CURL session
-behavior curl_worker(stateful_actor<curl_state>* self, actor parent) {
+behavior curl_worker(stateful_actor<curl_state>* self, const actor& parent) {
   if (!self->state.init("curl-worker", color::yellow))
     return {}; // returning an empty behavior terminates the actor
   return {
@@ -340,7 +340,7 @@ void caf_main(actor_system& system) {
   struct sigaction act;
   act.sa_handler = [](int) { shutdown_flag = true; };
   auto set_sighandler = [&] {
-    if (sigaction(SIGINT, &act, 0)) {
+    if (sigaction(SIGINT, &act, nullptr) != 0) {
       std::cerr << "fatal: cannot set signal handler" << std::endl;
       abort();
     }

examples/dynamic_behavior/dining_philosophers.cpp

@@ -5,6 +5,7 @@
 
 #include <map>
 #include <thread>
+#include <utility>
 #include <vector>
 #include <chrono>
 #include <sstream>
@@ -34,7 +35,8 @@ using think_atom = atom_constant<atom("think")>;
 using chopstick = typed_actor<replies_to<take_atom>::with<taken_atom, bool>,
                               reacts_to<put_atom>>;
 
-chopstick::behavior_type taken_chopstick(chopstick::pointer, strong_actor_ptr);
+chopstick::behavior_type taken_chopstick(chopstick::pointer,
+                                         const strong_actor_ptr&);
 
 // either taken by a philosopher or available
 chopstick::behavior_type available_chopstick(chopstick::pointer self) {
@@ -50,7 +52,7 @@ chopstick::behavior_type available_chopstick(chopstick::pointer self) {
 }
 
 chopstick::behavior_type taken_chopstick(chopstick::pointer self,
-                                         strong_actor_ptr user) {
+                                         const strong_actor_ptr& user) {
   return {
     [](take_atom) -> std::tuple<taken_atom, bool> {
       return std::make_tuple(taken_atom::value, false);
@@ -94,13 +96,13 @@ chopstick::behavior_type taken_chopstick(chopstick::pointer self,
 class philosopher : public event_based_actor {
 public:
   philosopher(actor_config& cfg,
-              const std::string& n,
-              const chopstick& l,
-              const chopstick& r)
+              std::string  n,
+              chopstick  l,
+              chopstick  r)
       : event_based_actor(cfg),
-        name_(n),
-        left_(l),
-        right_(r) {
+        name_(std::move(n)),
+        left_(std::move(l)),
+        right_(std::move(r)) {
     // we only accept one message per state and skip others in the meantime
     set_default_handler(skip);
     // a philosopher that receives {eat} stops thinking and becomes hungry

examples/message_passing/delegating.cpp

@@ -12,15 +12,15 @@ using namespace caf;
 
 using calc = typed_actor<replies_to<add_atom, int, int>::with<int>>;
 
-void actor_a(event_based_actor* self, calc worker) {
+void actor_a(event_based_actor* self, const calc& worker) {
   self->request(worker, std::chrono::seconds(10), add_atom::value, 1, 2).then(
     [=](int result) {
       aout(self) << "1 + 2 = " << result << endl;
     }
   );
 }
 
-calc::behavior_type actor_b(calc::pointer self, calc worker) {
+calc::behavior_type actor_b(calc::pointer self, const calc& worker) {
   return {
     [=](add_atom add, int x, int y) {
       return self->delegate(worker, add, x, y);