first draft of Books - Basket scenarios#2
Open
appendixshuffle wants to merge 6 commits intoalbumprinter:masterfrom
Open
first draft of Books - Basket scenarios#2appendixshuffle wants to merge 6 commits intoalbumprinter:masterfrom
appendixshuffle wants to merge 6 commits intoalbumprinter:masterfrom
Conversation
added 5 commits
January 17, 2023 18:42
cleaning comments, skips user-registration basic scenarios and pageObjectModels added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generally I’m trating this as a first oteration, so I tried to open topics, as much as I can for later implementations.
That’s why I’ve skipped some of scenarios, leaving empty dir’s or empty-skeleton .spec files.
I skipped also some of the refactor parts to not lose the goal of this exercise, but I left TODO comments in the code ( which nortmally im not doing msuch things - it should be tracked as a issues in repo or JIRA tasks )
Order of the next iterations is from top to down in test_plan.txt where you can find List with desc.
Few things discovered during this exercise :
- Tagging tests would be usefull to implement in the beginning : https://playwright.dev/docs/test-annotations#tag-tests