Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalidate MAv2 mode when mode changes #1366

Closed
wants to merge 4 commits into from

Conversation

jakehobbs
Copy link
Member

@jakehobbs jakehobbs commented Feb 14, 2025

Pull Request Checklist


PR-Codex overview

This PR focuses on refactoring and enhancing the account management logic, particularly around the ModularAccountV2 type, and streamlining hooks and components for better integration with configurations and account states.

Detailed summary

  • Removed useMint7702.tsx and integrated its functionality into useMint.tsx.
  • Updated useAccount calls to include skipCreate: true.
  • Enhanced UserConnectionAvatar and UserConnectionDetails components to utilize updated account and wallet type logic.
  • Refactored getAccount to use parameters instead of destructuring.
  • Consolidated minting logic in MintCard components to utilize a unified useMint hook.
  • Added handling for account mode validation in account creation and client retrieval functions.
  • Improved state management in createAccount to account for account configuration changes.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Feb 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 6:32pm
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 6:32pm

Copy link

graphite-app bot commented Feb 14, 2025

How to use the Graphite Merge Queue

Add the label graphite-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@jakehobbs
Copy link
Member Author

Closing in favor of #1361.

@jakehobbs jakehobbs closed this Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant