Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump eslint v9 #54

Closed
wants to merge 1 commit into from
Closed

Conversation

JCaiDev
Copy link
Contributor

@JCaiDev JCaiDev commented Nov 7, 2024

bump eslint v9
node v22

please review eslint v9 - it had a dep issues with @typescript-eslint/parser

Comment on lines +18 to +21
"@typescript-eslint/eslint-plugin": "^8.13.0",
"@typescript-eslint/parser": "^8.13.0",
"clsx": "^2.1.0",
"eslint-plugin-react": "^7.37.2",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are still dev dependencies

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does that mean?

Comment on lines +9 to +12
const GLOBALS_BROWSER_FIX = Object.assign({}, globals.browser, {
AudioWorkletGlobalScope: globals.browser["AudioWorkletGlobalScope "],
});
delete GLOBALS_BROWSER_FIX["AudioWorkletGlobalScope "];
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this for?

Copy link
Contributor Author

@JCaiDev JCaiDev Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there was an issue and warnings when i tried to bump eslint v9

and found this link sindresorhus/globals#239

@@ -0,0 +1,64 @@
import { fixupConfigRules } from "@eslint/compat";
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need compat or FlatCompat anymore, as all the plugins/configs that we are using are now compatible with v9. Can you check again?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was getting errors so i followed this
https://eslint.org/blog/2024/05/eslint-compatibility-utilities/

@JCaiDev
Copy link
Contributor Author

JCaiDev commented Nov 28, 2024

I am really not to sure what I was doing here and how to work on this issue

@alcpereira
Copy link
Owner

As this PR is stale, I will close it. Please feel free to reopen it once ready 🙏

@alcpereira alcpereira closed this Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants