Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(projects): prevent app crash when no projects exist #57

Conversation

ErimTuzcuoglu
Copy link
Contributor

Fixes app crash when there is no projects section or it is empty in "data.json".

Fixes #56

@ErimTuzcuoglu ErimTuzcuoglu force-pushed the fix/56-app-crash-without-projects-section branch from 0b2491a to e758b46 Compare February 1, 2025 21:46
Copy link
Owner

@alcpereira alcpereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution 🙏

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous version (commit) was closer to my initial thought for the fix. Do you mind update it back to the previous commit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest version fixes for all categories, but if we want to fix only projects category I can update it to back.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now the focus is only the project category, as it was a blocker for an user that contacted me.
FYI I plan to do a large refactor of the whole project with #39, the present issue is just a temporary fix until this refactor is done.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I updated it back, thanks

@ErimTuzcuoglu ErimTuzcuoglu force-pushed the fix/56-app-crash-without-projects-section branch from e758b46 to 29482a3 Compare February 3, 2025 00:01
@alcpereira alcpereira merged commit cc1d242 into alcpereira:main Feb 3, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

With no Projects section, the app breaks
2 participants