Skip to content

Update alerta_prometheus.py to honor the silence from ack setting #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update alerta_prometheus.py to honor the silence from ack setting #359

wants to merge 1 commit into from

Conversation

@dakotacody
Copy link
Contributor

@dakotacody dakotacody commented Jun 4, 2021

  1. ALERTMANAGER_SILENCE_FROM_ACK variable was not being honored to actually disable the silence from an ack.
  2. Set the silence seconds if ALERTMANAGER_SILENCE_DAYS variable is not set.
  3. If a silence is found for an alert that is getting a status change of open or closed we should probably remove the silence in alertmanager if it exists.

@dakotacody
Update alerta_prometheus.py
75b8efb 
1. ALERTMANAGER_SILENCE_FROM_ACK variable was not being honored to actually disable the silence from an ack.  
2. Set the silence seconds if ALERTMANAGER_SILENCE_DAYS variable is not set. 
3. If a silence is found for an alert that is getting a status change of open or closed we should probably remove the silence in alertmanager if it exists.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dakotacody