Skip to content

Commit

Permalink
Merge pull request openshift#4184 from ashcrow/rslave
Browse files Browse the repository at this point in the history
Merged by openshift-bot
  • Loading branch information
OpenShift Bot authored May 14, 2017
2 parents 9cbe2b7 + 08787d2 commit f20bf53
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 12 deletions.
26 changes: 15 additions & 11 deletions roles/docker/tasks/systemcontainer_docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,20 @@
state: present
when: not openshift.common.is_atomic | bool

# Make sure Docker is installed so we are able to use the client
- name: Install Docker so we can use the client
package: name=docker{{ '-' + docker_version if docker_version is defined else '' }} state=present
when: not openshift.common.is_atomic | bool

# Make sure docker is disabled. Errors are ignored.
- name: Disable Docker
systemd:
name: docker
enabled: no
state: stopped
daemon_reload: yes
ignore_errors: True

# Set http_proxy and https_proxy in /etc/atomic.conf
- block:

Expand Down Expand Up @@ -78,17 +92,7 @@
command: "atomic pull --storage ostree {{ l_docker_image }}"
changed_when: false

# Make sure docker is disabled Errors are ignored as docker may not
# be installed.
- name: Disable Docker
systemd:
name: docker
enabled: no
state: stopped
daemon_reload: yes
ignore_errors: True

- name: Ensure docker.service.d directory exists
- name: Ensure container-engine.service.d directory exists
file:
path: "{{ container_engine_systemd_dir }}"
state: directory
Expand Down
2 changes: 1 addition & 1 deletion roles/openshift_facts/library/openshift_facts.py
Original file line number Diff line number Diff line change
Expand Up @@ -1302,7 +1302,7 @@ def get_version_output(binary, version_cmd):
def get_docker_version_info():
""" Parses and returns the docker version info """
result = None
if is_service_running('docker'):
if is_service_running('docker') or is_service_running('container-engine'):
version_info = yaml.safe_load(get_version_output('/usr/bin/docker', 'version'))
if 'Server' in version_info:
result = {
Expand Down

0 comments on commit f20bf53

Please sign in to comment.