This repository was archived by the owner on Jan 16, 2024. It is now read-only.
Adds rewind function to allow curl seek and retry sending data to server - #1529
Open
jbfitb wants to merge 1 commit into
Open
Adds rewind function to allow curl seek and retry sending data to server#1529jbfitb wants to merge 1 commit into
jbfitb wants to merge 1 commit into
Conversation
Contributor
|
Hi @jbfitb, Thank you for the pull request. Our process is to make changes internally and run all test before pushing the change to github in the form of a new release. I have added this to our internal tracking system to be assessed and prioritized. Thanks, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
ACSDK_EMIT_SENSITIVE_LOGSto output curl error messages and me help investigate what was going on"necessary data rewind wasn't possible":CURLOPT_SEEKFUNCTIONand settingCURLOPT_SEEKDATAwill solve this problemAttachmentReaderalready has a seek function which mirrors the implementation ofCURLOPT_SEEKFUNCTION: Both expect to be able to set the absolute index of the buffer instead of changing the cursor by some delta.Description of changes:
CURLOPT_SEEKFUNCTIONrewindfunction to the read callbacksseekonAttachmentReaderwhen called from curlTesting:
Was able to build and run automated tests. This seems to fix the issue. No more 56 or 65 errors.