Skip to content

Add shortcuts for duplicating and deleting lines #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
diepfote wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add shortcuts for duplicating and deleting lines #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b50095
Add shortcuts for duplicating and deleting lines
diepfote Jan 7, 2018
aa6137d
Fix not deleting selection if present; fix not duplicating selection …
diepfote Dec 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion data/ui/gummi.glade
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1496,7 +1496,7 @@
<property name="use_underline">True</property>
<property name="image">image9</property>
<property name="use_stock">False</property>
<accelerator key="e" signal="activate" modifiers="GDK_CONTROL_MASK"/>
<accelerator key="p" signal="activate" modifiers="GDK_SHIFT_MASK | GDK_CONTROL_MASK"/>
<signal name="activate" handler="on_menu_export_activate" swapped="no"/>
</object>
</child>
Expand Down Expand Up @@ -1675,6 +1675,30 @@
<signal name="activate" handler="on_menu_delete_activate" swapped="no"/>
</object>
</child>
<child>
<object class="GtkImageMenuItem" id="menu_duplicate_line">
<property name="label" translatable="yes">Duplicate Line</property>
<property name="use_action_appearance">False</property>
<property name="visible">True</property>
<property name="can_focus">False</property>
<property name="use_underline">True</property>
<property name="use_stock">False</property>
<accelerator key="e" signal="activate" modifiers="GDK_CONTROL_MASK"/>
<signal name="activate" handler="on_menu_duplicate_line_activate" swapped="no"/>
</object>
</child>
<child>
<object class="GtkImageMenuItem" id="menu_delete_line">
<property name="label" translatable="yes">Delete Line</property>
<property name="use_action_appearance">False</property>
<property name="visible">True</property>
<property name="can_focus">False</property>
<property name="use_underline">True</property>
<property name="use_stock">False</property>
<accelerator key="d" signal="activate" modifiers="GDK_CONTROL_MASK"/>
<signal name="activate" handler="on_menu_delete_line_activate" swapped="no"/>
</object>
</child>
<child>
<object class="GtkSeparatorMenuItem" id="separator4">
<property name="visible">True</property>
Expand Down
2 changes: 1 addition & 1 deletion src/gui/gui-main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ const gchar* insens_widgets_str[] = {
"tool_left", "tool_center", "tool_right", "menu_save", "menu_saveas",
"menu_exportpdf", "import_tabs", "menu_close", "menu_export",
"menu_undo", "menu_redo", "menu_cut", "menu_copy", "menu_paste",
"menu_delete", "menu_selectall", "menu_preferences", "menu_find",
"menu_delete", "menu_selectall", "menu_duplicate_line", "menu_delete_line", "menu_preferences", "menu_find",
"menu_prev", "menu_next", "menu_pdfcompile", "menu_compileopts",
"menu_runmakeindex", "menu_runbibtex", "menu_docstat", "menu_spelling",
"menu_snippets", "menu_edit", "menu_document", "menu_search",
Expand Down
57 changes: 57 additions & 0 deletions src/gui/gui-menu.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,63 @@ void on_menu_export_activate (GtkWidget *widget, void *user) {
g_free (filename);
}

G_MODULE_EXPORT
void on_menu_duplicate_line_activate (GtkWidget *widget, void *user) {
GtkTextIter start, end;
gboolean has_selection = gtk_text_buffer_get_selection_bounds (g_e_buffer, &start, &end);

if (has_selection) {
gchar* entire_content = gtk_text_buffer_get_text (g_e_buffer, &start, &end, TRUE);
gtk_text_buffer_insert_at_cursor (g_e_buffer, entire_content, strlen (entire_content));
g_free (entire_content);
} else {
GtkTextMark* insert_mark = gtk_text_buffer_get_insert (g_e_buffer);

GtkTextIter insert_mark_position;
gtk_text_buffer_get_iter_at_mark (g_e_buffer, &insert_mark_position, insert_mark);

gint line_of_insert = gtk_text_iter_get_line (&insert_mark_position);
gint line_after_insert = line_of_insert + 1;

GtkTextIter start_of_line;
gtk_text_buffer_get_iter_at_line (g_e_buffer, &start_of_line, line_of_insert);

GtkTextIter end_of_line;
gtk_text_buffer_get_iter_at_line (g_e_buffer, &end_of_line, line_after_insert);

gchar* current_line_content = gtk_text_buffer_get_text (g_e_buffer, &start_of_line, &end_of_line, 1);
gint length_of_current_line_content = strlen (current_line_content);
gtk_text_buffer_insert (g_e_buffer, &end_of_line, current_line_content, length_of_current_line_content);
g_free (current_line_content);
}
}

G_MODULE_EXPORT
void on_menu_delete_line_activate (GtkWidget *widget, void *user) {
GtkTextMark* insert_mark = gtk_text_buffer_get_insert (g_e_buffer);

GtkTextIter insert_mark_position;
gtk_text_buffer_get_iter_at_mark (g_e_buffer, &insert_mark_position, insert_mark);

gint line_of_insert = gtk_text_iter_get_line (&insert_mark_position);
gint line_after_insert = line_of_insert + 1;

GtkTextIter start_of_line;
gtk_text_buffer_get_iter_at_line (g_e_buffer, &start_of_line, line_of_insert);

GtkTextIter end_of_line;
gtk_text_buffer_get_iter_at_line (g_e_buffer, &end_of_line, line_after_insert);

GtkTextIter start, end;
gboolean has_selection = gtk_text_buffer_get_selection_bounds (g_e_buffer, &start, &end);

if (has_selection)
gtk_text_buffer_delete_selection (g_e_buffer, FALSE, TRUE);
else
// cannot be undone in case of multiple calls/lines deleted
gtk_text_buffer_delete (g_e_buffer, &start_of_line, &end_of_line);
}

G_MODULE_EXPORT
void on_menu_recent_activate (GtkWidget *widget, void *user) {
const gchar* name = gtk_menu_item_get_label (GTK_MENU_ITEM (widget));
Expand Down