Font-awesome update + icons from /images and simpleicons #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiCiT
commented
Feb 25, 2025
JiCiT
commented
- Updates font-awesome to v6.7.2.
- Adds option to additionally use icons from local /images/ and simpleicons.com
- Requires breaking changes to the pelicanconf.py SOCIAL variable.
- Should include simultaneous updates to wiki if merged.
…older.
Requires modifcation of pelicanconf.py SOCIAL setting like:
SOCIAL = (
("facebook", "fa", "https://www.facebook.com/profile.php?id=61573521776881"),
("nextdoor", "local", "https://nextdoor.com/profile/01rH_psxZ8CTP-R6P"),
("x-twitter", "fa", "https://x.com/JiCiT72"),
("github", "fa", "https://github.com/JiCiT/"),
)
The second parameter being the icon location: fa = font-awesome; si = simpleicons; local = static/images folder
alexandrevicenzi
requested changes
Mar 4, 2025
Owner
alexandrevicenzi
left a comment
alexandrevicenzi
left a comment
There was a problem hiding this comment.
There's no need for simpleicons when FA is available, plus it breaks compatibility.
Author
|
Sure, no worries. Just offering it up. Feel free to cherry pick whatever, if anything, you do like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.