write_addr_reg unused debug #4
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debug the dangerous use of write_addr, should use write_addr_reg in your original code design. This bug could cause unexpected write/erase action if write_addr is not stable in the next clk of write_enable.
Your testbench may need to be modified, too. But I can't run your testbench on my computer. :D
Testbench modification may like this:
# write some data
write_addr.next = 0
write_data.next = 0x0123456789ABCDEF
write_delete.next = 0
write_enable.next = 1
yield clk.posedge
write_enable.next = 0
yield clk.posedge
to
# write some data
write_addr.next = 0
write_data.next = 0x0123456789ABCDEF
write_delete.next = 0
write_enable.next = 1
yield clk.posedge
write_addr.next = 0
write_data.next = 0
write_delete.next = 0
write_enable.next = 0
yield clk.posedge
THANKS FOR YOUR PROJECT A LOT!