Skip to content

Fixed NukeIntegration and README #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed NukeIntegration and README #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ While AXPhotoViewer has many configurable properties on each of its modules, it

```swift
let dataSource = AXPhotosDataSource(photos: self.photos)
let photosViewController = PhotosViewController(dataSource: dataSource)
let photosViewController = AXPhotosViewController(dataSource: dataSource)
self.present(photosViewController, animated: true)
```

Expand Down
14 changes: 8 additions & 6 deletions Source/Integrations/NukeIntegration.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,24 +33,26 @@ class NukeIntegration: NSObject, AXNetworkIntegrationProtocol {
}
}

let completion: ImageTask.Completion = { [weak self] (response, error) in
let completion: ImageTask.Completion = { [weak self] (result) in
guard let `self` = self else { return }

self.retrieveImageTasks.removeObject(forKey: photo)

if let imageData = response?.image.animatedImageData {
switch result {
case let .success(response):
if let imageData = response.image.animatedImageData {
photo.imageData = imageData
AXDispatchUtils.executeInBackground { [weak self] in
guard let `self` = self else { return }
self.delegate?.networkIntegration(self, loadDidFinishWith: photo)
}
} else if let image = response?.image {
photo.image = image
} else {
photo.image = response.image
AXDispatchUtils.executeInBackground { [weak self] in
guard let `self` = self else { return }
self.delegate?.networkIntegration(self, loadDidFinishWith: photo)
}
} else {
}
case .failure:
let error = NSError(
domain: AXNetworkIntegrationErrorDomain,
code: AXNetworkIntegrationFailedToLoadErrorCode,
Expand Down