perf: ingestion work and preview cloning - #1122
Merged
Merged
Conversation
The reader loop paid per-line costs (an async read_until, a buffer clone and an Instant::now) which dominated ingestion time on large sources. Read the pipe in large chunks instead and ship complete entries to the blocking tasks, which now also split the lines. Loading 3.5M lines end-to-end goes from ~0.76s to ~0.23s.
Generating a preview deep-copied the parsed Text twice when caching (once for the preview, once for the cache) and every cache hit copied it again; arriving previews were also compared structurally against the current one. Share the text behind an Arc instead: the cache stores and returns Arc clones, and a pointer check now short-circuits the content comparison. Bouncing between two cached ~200k-line previews drops from ~130ms of CPU per selection change to ~10ms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.