Make https support really work: #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- need to set `use_ssl` to true
- also cannot use `get_response` class method for https requests
- add a smoke_test that calls out to google for real, to make sure
things work end to end (not using test_helper for this, because it's invasive
and opens code under test to do it's mocking)
- add smoke_test to default test run
alexreisner
added a commit
that referenced
this pull request
Sep 27, 2011
Fix HTTPS support (thanks github.com/rsanheim).
|
Looks great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use_sslto trueget_responseclass method for https requeststhings work end to end (not using test_helper for this, because it's invasive
and opens code under test to do it's mocking)