Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(specs): add new realtime key to config endpoints [PRED-3615] #4481

Merged
merged 3 commits into from
Apr 7, 2025

Conversation

bengreenbank
Copy link
Contributor

@bengreenbank bengreenbank commented Feb 19, 2025

🧭 What and Why

Update the configuration endpoint to account for the latest changes, including the new 'features' property.

🎟 JIRA Ticket: PRED-3615

Changes included:

  • Add features property
  • Add realtime values

🧪 Test

  • Green CI (no clients generated for AI Perso API)

@bengreenbank bengreenbank changed the title feat(specs): add new realtime key to get and put config endpoints [PRED-3615] feat(specs): add new realtime key to config endpoints [PRED-3615] Feb 19, 2025
@algolia-bot
Copy link
Collaborator

algolia-bot commented Feb 19, 2025

✔️ Code generated!

Name Link
🪓 Triggered by bdc400f752f662b93c09c40297ea8107f7d61616
🍃 Generated commit a8c59a16dee1d8b73bf02128030a1b33fc14b72f
🌲 Generated branch generated/feat/adv-perso/realtime-feature-pred-3615
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1614
javascript 1562
php 1555
csharp 1348
java 1092
python 1087
swift 858
ruby 801
scala 23

@bengreenbank bengreenbank force-pushed the feat/adv-perso/realtime-feature-pred-3615 branch from 026d004 to e5c6e31 Compare April 7, 2025 10:11
@bengreenbank bengreenbank force-pushed the feat/adv-perso/realtime-feature-pred-3615 branch from e5c6e31 to 1c0a8e5 Compare April 7, 2025 10:16
@bengreenbank bengreenbank marked this pull request as ready for review April 7, 2025 10:25
@bengreenbank bengreenbank requested a review from a team as a code owner April 7, 2025 10:25
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good ! small comment about support url

type: string
description: Details about the response, such as error messages.
enum:
- "Predictive profiles are not allowed for this app. Please contact support to upgrade your plan: https://support.algolia.com/"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we use the link https://alg.li/support in the doc and spec to refer to support, is this another support page ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the link that the short URL redirects to. I can make a note to use this in our API responses, but it won't be a priority.

@bengreenbank bengreenbank requested a review from millotp April 7, 2025 12:47
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my comment is non blocking actually, this looks good !
Do you want me to merge this right now ?

@bengreenbank
Copy link
Contributor Author

Do you want me to merge this right now ?

Yes please, the API is live already.

@millotp millotp requested a review from a team as a code owner April 7, 2025 13:02
@millotp millotp requested review from morganleroi and shortcuts April 7, 2025 13:02
@millotp millotp enabled auto-merge (squash) April 7, 2025 13:06
@millotp millotp merged commit cf090b7 into main Apr 7, 2025
28 checks passed
@millotp millotp deleted the feat/adv-perso/realtime-feature-pred-3615 branch April 7, 2025 13:16
algolia-bot added a commit that referenced this pull request Apr 7, 2025
) (generated) [skip ci]

Co-authored-by: Ben Greenbank <[email protected]>
Co-authored-by: Pierre Millot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants