-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(specs): add new realtime key to config endpoints [PRED-3615] #4481
Conversation
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
026d004
to
e5c6e31
Compare
e5c6e31
to
1c0a8e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good ! small comment about support url
type: string | ||
description: Details about the response, such as error messages. | ||
enum: | ||
- "Predictive profiles are not allowed for this app. Please contact support to upgrade your plan: https://support.algolia.com/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we use the link https://alg.li/support in the doc and spec to refer to support, is this another support page ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the link that the short URL redirects to. I can make a note to use this in our API responses, but it won't be a priority.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my comment is non blocking actually, this looks good !
Do you want me to merge this right now ?
Yes please, the API is live already. |
) (generated) [skip ci] Co-authored-by: Ben Greenbank <[email protected]> Co-authored-by: Pierre Millot <[email protected]>
🧭 What and Why
Update the configuration endpoint to account for the latest changes, including the new 'features' property.
🎟 JIRA Ticket: PRED-3615
Changes included:
🧪 Test