Skip to content

Merging my current work into COURSIZ main#47

Open
AhmedAbdelRaheem1 wants to merge 8 commits intomainfrom
AbdelRahimo
Open

Merging my current work into COURSIZ main#47
AhmedAbdelRaheem1 wants to merge 8 commits intomainfrom
AbdelRahimo

Conversation

@AhmedAbdelRaheem1
Copy link
Collaborator

No description provided.

Copy link
Owner

@alhusseain alhusseain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just drop the SQL file, the professors file, users file, and the sign in file when merging.....I already handled the SQL code and will handle the sign-in file

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already done users

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really promising work!! would make it alot easier for me to integrate

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As with users, this class is wrong And I will take care of it...so drop it

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

helpful stuff

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will test this file and come back to you...since github seems to reject this file

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is unneeded... since it is already implemented by kareem in app.py, and the sign-up and sign-in functions will be parts of users, teachers, and supervisors classes, not that it will have a file on its own

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have done some modifications and merged this myself to the main.....you can check it and give me your thoughts...

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the role of this file?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to merge this anymore......

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants