Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ai-cache extension #1746

Merged
merged 2 commits into from
Feb 13, 2025
Merged

update ai-cache extension #1746

merged 2 commits into from
Feb 13, 2025

Conversation

mirror58229
Copy link
Contributor

Ⅰ. Describe what this PR did

  1. Change ctx.DontReadRequestBody to ctx.DontReadResponseBody in onHttpRequestBody
  2. Move the logic for checking ERROR_PARTIAL_MESSAGE_KEY to onHttpResponseBody. The previous logic would not work correctly because a response may have only one header but multiple bodies.
  3. Update the documentation to reflect that the cache database will be used first when both configured.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.61%. Comparing base (ef31e09) to head (05e3833).
Report is 287 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1746      +/-   ##
==========================================
+ Coverage   35.91%   43.61%   +7.70%     
==========================================
  Files          69       76       +7     
  Lines       11576    12358     +782     
==========================================
+ Hits         4157     5390    +1233     
+ Misses       7104     6630     -474     
- Partials      315      338      +23     

see 70 files with indirect coverage changes

Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit 7272eff into alibaba:main Feb 13, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants