Repository navigation
Conversation
Client Request.Host is optional; when empty the transport uses URL.Host. Populate server.address from URL.Host in that case so http.client metrics keep a usable peer dimension.
Strip :port from Request.Host / URL host so server.address stays hostname-or-IP per OTel semconv, and cover IPv4/IPv6 cases in tests.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
net/httpclient instrumentation previously setserver.addressonly fromRequest.Host.Hostis optional and may be empty whileURL.Hostis set; the transport still works, but metrics/spans gotserver.address="".request.url.HostwhenHostis empty.GetServerPortis unchanged.Test plan
go test -run TestNetHttpClientGetServerAddress ./pkg/rules/httphttp.client.request.durationpoints no longer emit emptyserver.addressfor requests constructed with emptyRequest.Hostand non-emptyURL.Host