MI-206: Have CI_DEBUG affect package manager install command(s) #13
Conversation
This change allows us to see more detail when the package manager fails for whatever reason. For most package managers, the specific error message when not using `--verbose` (for example) only include a fairly generic error, even if the error is unrecoverable.
There was a problem hiding this comment.
Look great, @toddhainsworth
I'm so happy that there is someone else who cares about this repo.
lib/packageManagers.ts
Outdated
| return 'yarn install --frozen-lockfile'; | ||
| export function getInstallCommand( | ||
| packageManager: PackageManager, | ||
| debug: boolean = false, |
There was a problem hiding this comment.
I think we can just import the global debug environment variables instead of passing it in as a parameter like this. Check out how it is setup in injectCfnRole.ts file:
import { env } from './env';
if (env.debug) {
console.log(
logSymbols.info,
chalk.whiteBright(JSON.stringify(serverless, null, 2))
);
}There was a problem hiding this comment.
Good pickup! Thanks, I'll update.
| const installCommands: Record<PackageManager, string> = { | ||
| npm: 'npm ci', | ||
| pnpm: 'pnpm install --frozen-lockfile', | ||
| yarn: 'yarn install --frozen-lockfile', |
There was a problem hiding this comment.
We should update this. yarn no longer use --frozen-lockfile. the correct flag is now --immutable
There was a problem hiding this comment.
Another great pickup! Do we need to decide based on the Yarn version or are we happy to only support versions >= the version that introduced --immutable?
There was a problem hiding this comment.
It's there in Yarn Berry since version 2.0.0. I think it's safe for us to assume that no one ever run this pipeline in Yarn Classic. If they ever do it, probably they made another mistake and need to upgrade their package manager to Yarn Berry 😄
There was a problem hiding this comment.
Excellent - pushed a change to use --immutable
There was a problem hiding this comment.
Haha, Use --immutable for Yarn and debug from environment didn't actually use --immutable 🤣 .
|
Thanks guys, ready for another review. |
3 participants
This change allows us to see more detail when the package manager fails for whatever reason. For most package managers, the specific error message when not using
--verbose(for example) only include a fairly generic error, even if the error is unrecoverable.