JAN-1120: Setup SSH configuration #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows projects with NPM dependencies that are bought in via Git SSH to be installable.
|
Looks ok to me but definitely want a DevOps approval on this one. |
TheOrangePuff
requested changes
Apr 9, 2025
lib/ssh.ts
Outdated
| console.error( | ||
| 'Failed to update SSH configuration, check that SSH key configuration in Pipelines is valid. \n Check Pipelines -> SSH Keys.' | ||
| ); | ||
| throw e; |
There was a problem hiding this comment.
Can we just gracefully continue here? We don't need SSH keys to deploy, it's only needed if installing packages via ssh
There was a problem hiding this comment.
That's a good point 😅
TheOrangePuff
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows projects with NPM dependencies that are bought in via Git SSH to be installable.
Essentially a Node-ification of https://github.com/aligent/serverless-deploy-pipe/blob/main/pipe/pipe.py#L65