MI-267: Resolve Lambda handler asset paths for nested handler directories #1143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will handle nested folders in a more predictable way when bundling and resolving paths
…path-for-bundled-handlers Feature/mi 246 retain relative path for bundled handlers
…code MI-246: Bundle lambda code using vite
Release/v4.1.0
Bumps [form-data](https://github.com/form-data/form-data) from 4.0.3 to 4.0.4. - [Release notes](https://github.com/form-data/form-data/releases) - [Changelog](https://github.com/form-data/form-data/blob/master/CHANGELOG.md) - [Commits](form-data/form-data@v4.0.3...v4.0.4) --- updated-dependencies: - dependency-name: form-data dependency-version: 4.0.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Passing `scope` means the service stacks don't inherit things like the stage tag.
MI-262: (fix) ensure example service instantiation works
Bump the patch version of Nx and associated plugins
…ta-4.0.4 Bump form-data from 4.0.3 to 4.0.4
…nd-audit-commands-in-setup MI-259: Fix step 2 of setup documentation
Release/v4.1.1
…ries The resolveLambdaHandler function was not correctly resolving asset paths for Lambda handlers located in nested directories (e.g., runtime/handlers/prototype/salesforce/get-salesforce-object.ts). The function was preserving the full directory structure in the asset path, but the build process creates a flat structure in the dist directory. This caused deployment failures with errors like: ValidationError: Cannot find asset at /path/to/services/catalog-dist/dist/prototype/get-salesforce-object Changes: - Modified resolveLambdaHandler to extract only the filename from nested handler paths - Updated logic to correctly resolve runtime/handlers/prototype/get-salesforce-object.ts to ../dist/get-salesforce-object - Added clarifying comment about flat bundling structure - This maintains compatibility with the existing build process while allowing handlers to be organized in subdirectories.
|
@tvhees @kai-nguyen-aligent Repo might need some cleanup, 4.2.0 is behind |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resolveLambdaHandler function was not correctly resolving asset paths for Lambda handlers located in nested directories (e.g., runtime/handlers/prototype/salesforce/get-salesforce-object.ts).
The function was preserving the full directory structure in the asset path, but the build process creates a flat structure in the dist directory. This caused deployment failures with errors like: ValidationError: Cannot find asset at /path/to/services/catalog-dist/dist/prototype/get-salesforce-object
Changes: