-
Notifications
You must be signed in to change notification settings - Fork 148
fix: update dependencies to address security issue in @babel/runtime < 7.26.10 #375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 11 commits
7685c19
ad6e6be
20f6f57
00fcdd9
e199d57
d14ab08
6f89a2b
c039b3d
5a4237d
8df7603
9a16463
2043cac
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,23 @@ | ||
| version: 2.1 | ||
|
|
||
| orbs: | ||
| codecov: codecov/[email protected] | ||
|
|
||
| docker_defaults: &docker_defaults | ||
| docker: | ||
| - image: cimg/node:16.17.0 | ||
| - image: cimg/node:22.14 | ||
|
|
||
| commands: | ||
| prep_env: | ||
| description: Prepares environment with cache | ||
| steps: | ||
| - checkout: | ||
| path: ~/repo | ||
| - run: | ||
| name: Enable pnpm via Corepack | ||
| command: | | ||
| sudo corepack enable | ||
| corepack prepare [email protected] --activate | ||
| - restore_cache: | ||
| name: Restore node_modules cache | ||
| key: | ||
|
|
@@ -30,14 +38,14 @@ jobs: | |
| working_directory: ~/repo | ||
| steps: | ||
| - prep_env | ||
| - run: yarn install | ||
| - run: pnpm install | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. cool - i didn't know about pnpm!!
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we moved from yarn --> npm for the documentation i wonder if we should use this over in that repo too?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Although I personally love pnpm and use it in all my projects (template: create-typescript-app), switching this CLI from a previous package manager to pnpm is a big change. If we want to do that (+1 from me) it should be in a separate PR than a smaller "update dependencies" one.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Makes sense! |
||
| - save_env_cache | ||
| validate: | ||
| <<: *docker_defaults | ||
| working_directory: ~/repo | ||
| steps: | ||
| - prep_env | ||
| - run: yarn validate | ||
| - run: pnpm run validate | ||
| - persist_to_workspace: | ||
| root: ./ | ||
| paths: | ||
|
|
@@ -50,8 +58,8 @@ jobs: | |
| - prep_env | ||
| - attach_workspace: | ||
| at: ./ | ||
| - run: yarn codecov | ||
| - run: yarn semantic-release | ||
| - codecov/upload | ||
| - run: pnpm run semantic-release | ||
| workflows: | ||
| version: 2 | ||
| validate_and_deploy: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 16.17.0 | ||
| 22.14.0 |
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,13 +10,13 @@ | |
| "dist" | ||
| ], | ||
| "engines": { | ||
| "node": ">=4" | ||
| "node": ">=22" | ||
| }, | ||
| "scripts": { | ||
| "add-contributor": "kcd-scripts contributors add", | ||
| "build": "kcd-scripts build", | ||
| "lint": "kcd-scripts lint", | ||
| "test": "kcd-scripts test", | ||
| "test": "NODE_OPTIONS='--experimental-vm-modules' kcd-scripts test", | ||
| "validate": "kcd-scripts validate", | ||
| "commit": "git-cz", | ||
| "start": "./dist/cli.js", | ||
|
|
@@ -42,27 +42,25 @@ | |
| }, | ||
| "homepage": "https://github.com/all-contributors/all-contributors-cli#readme", | ||
| "dependencies": { | ||
| "@babel/runtime": "^7.7.6", | ||
| "async": "^3.1.0", | ||
| "chalk": "^4.0.0", | ||
| "didyoumean": "^1.2.1", | ||
| "inquirer": "^7.3.3", | ||
| "json-fixer": "^1.6.8", | ||
| "lodash": "^4.11.2", | ||
| "node-fetch": "^2.6.0", | ||
| "@babel/runtime": "^7.28.6", | ||
| "async": "^3.2.6", | ||
| "chalk": "^5.6.2", | ||
| "didyoumean": "^1.2.2", | ||
| "inquirer": "^12.9.6", | ||
| "json-fixer": "^1.6.15", | ||
| "lodash": "^4.17.21", | ||
| "pify": "^5.0.0", | ||
| "yargs": "^15.0.1" | ||
| "yargs": "^18.0.0" | ||
| }, | ||
| "devDependencies": { | ||
| "codecov": "^3.8.1", | ||
| "cz-conventional-changelog": "^3.3.0", | ||
| "git-cz": "^4.7.6", | ||
| "kcd-scripts": "^6.2.0", | ||
| "nock": "^12.0.0", | ||
| "semantic-release": "^17.0.8" | ||
| "git-cz": "^4.9.0", | ||
| "kcd-scripts": "^16.0.0", | ||
| "nock": "^14.0.10", | ||
| "semantic-release": "^24.2.9" | ||
| }, | ||
| "optionalDependencies": { | ||
| "prettier": "^2" | ||
| "prettier": "^3.8.0" | ||
| }, | ||
| "eslintIgnore": [ | ||
| "node_modules", | ||
|
|
@@ -83,5 +81,11 @@ | |
| "commitizen": { | ||
| "path": "cz-conventional-changelog" | ||
| } | ||
| } | ||
| }, | ||
| "pnpm": { | ||
| "overrides": { | ||
| "tmp": ">=0.2.4" | ||
| } | ||
| }, | ||
| "packageManager": "[email protected]" | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think i have access to circle ci so let me dig into that first. if this could be it's own pr we can merge it quickly as is