feat: Validate 3D source paths (3D paths pt. 2) #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShrimpCryptid
changed the title
ShrimpCryptid
force-pushed
the
fix/warn-invalid-3d-paths
branch
from
827876f to
69b7502
Compare
ShrimpCryptid
commented
Nov 24, 2025
| from colorizer_data.utils import ( | ||
| INITIAL_INDEX_COLUMN, | ||
| _get_frame_count_from_3d_source, | ||
| get_frame_count_from_3d_source, |
Contributor
Author
There was a problem hiding this comment.
Renamed this function
Comment on lines
+453
to
+455
| ("source") and channel ("segmentation_channel") to use for the 3D image source. The source | ||
| must be either a URL or a path inside the output dataset directory. If `None`, 3D frames | ||
| will not be included in the dataset. |
Contributor
Author
There was a problem hiding this comment.
I have an idea for supporting files outside the output dataset directory via symlinks, which I'll open as pt. 3 of this chain. For now, enforcing that paths must be inside the output dataset directory (or be a URL) will prevent loading errors, but it potentially requires users to move their (huge) Zarr data around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is the problem this work solves, including
Link to story or ticket
Solution
What I/we did to solve this problem
with @pairperson1
Type of change
Please delete options that are not relevant.
Change summary:
Steps to Verify:
Screenshots (optional):
Show-n-tell images/animations here
Keyfiles (delete if not relevant):
Thanks for contributing!