generated from allen-cell-animated/github-boilerplate
-
Notifications
You must be signed in to change notification settings - Fork 0
update vole-app and demo uses bioio #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
ab748ac
update vole-app and demo uses bioio
toloudis 4c29866
update actions
toloudis 87e658c
update yarn lock
toloudis b87d0a2
fix import
toloudis 86d732d
update some things
toloudis 762565b
try to fix lint
toloudis b153f0a
test out removing specific module resolutions
toloudis a2de9cf
re-add module resolution hints
toloudis d3043f1
fix typo
toloudis 94b6abe
one more syntax error I think
toloudis 4ab7665
fix download-artifact version
toloudis 3cbd26e
fix some peer dependency issues reported by jlpm
toloudis 4a03751
update yarn lock
toloudis be6e200
work on deps
toloudis e22cee4
add skipLibCheck
toloudis 2f2ca4b
cleanup and update some things
toloudis 725035e
allow raw dtype to pass through (but keep the resizing)
toloudis db05894
newline
toloudis a6f5e9e
bump vole-app
toloudis 9ca685a
bump app again
toloudis 2550231
add `ViewerStateProvider`, reorg view w/ TSX
frasercl 41984ef
newest viewer
toloudis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -82,17 +82,19 @@ def atlas_dimensions( | |
| "sizeY": tile_height, | ||
| "sizeZ": stack_height, | ||
| "sizeC": aics_image.shape[0], | ||
| "physicalPixelSize": physical_pixel_size if physical_pixel_size is not None else [1, 1, 1], | ||
| "physicalPixelSize": ( | ||
| physical_pixel_size if physical_pixel_size is not None else [1, 1, 1] | ||
| ), | ||
| "spatialUnit": "µm", | ||
| "channelNames": ( | ||
| "channelNames": ( | ||
| channel_names | ||
| if channel_names is not None | ||
| else ["CH_" + str(i) for i in range(aics_image.shape[0])] | ||
| ), | ||
| } | ||
|
|
||
| # "originalSize": [aics_image.shape[3], aics_image.shape[2], aics_image.shape[1]], | ||
|
|
||
| return dims | ||
|
|
||
|
|
||
|
|
@@ -118,7 +120,7 @@ def img_prep(img, shape=(128, 128)): | |
|
|
||
| # C Z Y X | ||
| response = numpy.zeros( | ||
| (channels, img.shape[1], shape[1], shape[0]), dtype=numpy.uint8 | ||
| (channels, img.shape[1], shape[1], shape[0]), dtype=img.dtype | ||
| ) | ||
|
|
||
| for channel_index in range(channels): | ||
|
|
@@ -127,11 +129,11 @@ def img_prep(img, shape=(128, 128)): | |
|
|
||
| resized_channel = resize(channel_data, (shape[0], shape[1])) | ||
|
|
||
| mn = min(0, resized_channel.min()) | ||
| mx = resized_channel.max() | ||
| resized_channel = 255.0 * (resized_channel - mn) / (mx - mn) | ||
| # atlas = np.interp(atlas, (min(0, atlas.min()), atlas.max()), (0.0, 255.0)) | ||
| resized_channel = resized_channel.astype(numpy.uint8) | ||
| # mn = min(0, resized_channel.min()) | ||
| # mx = resized_channel.max() | ||
| # resized_channel = 255.0 * (resized_channel - mn) / (mx - mn) | ||
|
|
||
| # resized_channel = resized_channel.astype(numpy.uint8) | ||
|
Comment on lines
+132
to
+136
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Curious why this is retained?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yeah I suppose we can just delete it |
||
|
|
||
| response[channel_index] = resized_channel | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can think of some other repos that could use this