Skip to content

Add Kaggle datasets #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Add Kaggle datasets #9

wants to merge 9 commits into from

Conversation

wengh
Copy link
Contributor

@wengh wengh commented Mar 27, 2025

The Kaggle data source is simply a wrapper around kagglehub.dataset_load which allows loading a dataset as a pandas dataframe.

Addition of Kaggle Data Source:

Documentation Updates:

  • docs/datasources/kaggle.md: Added documentation for the KaggleDataSource, including requirements and usage examples.
  • docs/index.md: Updated the index to include the KaggleDataSource in the list of available data sources.

Project Configuration:

  • pyproject.toml: Added the kagglehub library as an optional dependency for the project.

Testing:

  • tests/test_data_sources.py: Added a new test case for the KaggleDataSource to ensure it can read a dataset from Kaggle correctly.

@wengh
Copy link
Contributor Author

wengh commented Mar 27, 2025

@allisonwang-db
oops I accidentally closed #7 when rebasing

from functools import cached_property
from typing import Iterator

import pyarrow as pa
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have to depend on pyarrow? Can we throw a better error message if pyarrow is not installed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Depending on pyarrow should be fine since pyspark data source itself depends on pyarrow. Let's import pyarrow later so that pyspark shows the error message if it's missing.

Copy link
Owner

@allisonwang-db allisonwang-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants