Skip to content

Commit

Permalink
Fix nivo components types (#99)
Browse files Browse the repository at this point in the history
  • Loading branch information
epszaw authored Feb 13, 2025
1 parent b27ea84 commit 13d2bb6
Show file tree
Hide file tree
Showing 8 changed files with 24 additions and 56 deletions.
2 changes: 2 additions & 0 deletions .pnp.cjs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions packages/web-awesome/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
"@babel/preset-typescript": "^7.24.7",
"@eslint/js": "^9.10.0",
"@floating-ui/dom": "^1.6.12",
"@preact/compat": "^18.3.1",
"@stylistic/eslint-plugin": "^2.6.1",
"@types/babel__core": "^7.20.5",
"@types/d3-shape": "^3.1.6",
Expand Down
2 changes: 2 additions & 0 deletions packages/web-awesome/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,8 @@ export default (env, argv) => {
extensions: [".js", ".ts", ".tsx"],
alias: {
"@": join(baseDir, "src"),
"react": "@preact/compat",
"react-dom": "@preact/compat",
},
},
};
Expand Down
4 changes: 2 additions & 2 deletions packages/web-components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@
"build:ds": "storybook build",
"dev:ds": "storybook dev -p 6006",
"lint": "eslint --ext ts,tsx --report-unused-disable-directives --max-warnings 0",
"test": "vitest run",
"preinstall": "node ./scripts/addPreactAliases.js"
"test": "vitest run"
},
"dependencies": {
"@allurereport/web-commons": "workspace:*",
Expand All @@ -63,6 +62,7 @@
"@eslint/js": "^9.10.0",
"@nivo/axes": "^0.88.0",
"@nivo/legends": "^0.88.0",
"@preact/compat": "^18.3.1",
"@preact/preset-vite": "^2.9.4",
"@preact/signals": "^1.3.0",
"@rollup/plugin-alias": "^5.1.1",
Expand Down
33 changes: 0 additions & 33 deletions packages/web-components/scripts/addPreactAliases.js

This file was deleted.

6 changes: 6 additions & 0 deletions packages/web-components/src/types/nivo.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import { type LineSvgProps } from "@nivo/line";
import { type Component } from "preact";

declare module "@nivo/line" {
export interface ResponsiveLine extends Component<LineSvgProps> {}
}
12 changes: 0 additions & 12 deletions packages/web-components/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,18 +28,6 @@
"paths": {
"@/*": [
"src/*"
],
"react": [
"../../.yarn/cache/preact-npm-10.24.0-1e922a9bf3-855506eedf.zip/node_modules/preact/compat/"
],
"react/jsx-runtime": [
"../../.yarn/cache/preact-npm-10.24.0-1e922a9bf3-855506eedf.zip/node_modules/preact/jsx-runtime/"
],
"react-dom": [
"../../.yarn/cache/preact-npm-10.24.0-1e922a9bf3-855506eedf.zip/node_modules/preact/compat/"
],
"react-dom/*": [
"../../.yarn/cache/preact-npm-10.24.0-1e922a9bf3-855506eedf.zip/node_modules/preact/compat/*"
]
},
"resolveJsonModule": true,
Expand Down
20 changes: 11 additions & 9 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -626,6 +626,7 @@ __metadata:
"@babel/preset-typescript": "npm:^7.24.7"
"@eslint/js": "npm:^9.10.0"
"@floating-ui/dom": "npm:^1.6.12"
"@preact/compat": "npm:^18.3.1"
"@preact/signals": "npm:^1.3.0"
"@stylistic/eslint-plugin": "npm:^2.6.1"
"@types/babel__core": "npm:^7.20.5"
Expand Down Expand Up @@ -805,6 +806,7 @@ __metadata:
"@nivo/core": "npm:^0.88.0"
"@nivo/legends": "npm:^0.88.0"
"@nivo/line": "npm:^0.88.0"
"@preact/compat": "npm:^18.3.1"
"@preact/preset-vite": "npm:^2.9.4"
"@preact/signals": "npm:^1.3.0"
"@rollup/plugin-alias": "npm:^5.1.1"
Expand Down Expand Up @@ -5424,6 +5426,15 @@ __metadata:
languageName: node
linkType: hard

"@preact/compat@npm:^18.3.1, react-dom@npm:@preact/compat@*, react@npm:@preact/compat@*":
version: 18.3.1
resolution: "@preact/compat@npm:18.3.1"
peerDependencies:
preact: "*"
checksum: 10/c3a457a5496672207a276f89961ae725ca811c42a37865bac66fe636473805ac4bf6bcf333b2745fe4da874ccd8a5293020a5b353b027bc532ca74b3610dac37
languageName: node
linkType: hard

"@preact/preset-vite@npm:^2.9.4":
version: 2.10.0
resolution: "@preact/preset-vite@npm:2.10.0"
Expand Down Expand Up @@ -17510,15 +17521,6 @@ __metadata:
languageName: node
linkType: hard

"react-dom@npm:@preact/compat@*, react@npm:@preact/compat@*":
version: 18.3.1
resolution: "@preact/compat@npm:18.3.1"
peerDependencies:
preact: "*"
checksum: 10/c3a457a5496672207a276f89961ae725ca811c42a37865bac66fe636473805ac4bf6bcf333b2745fe4da874ccd8a5293020a5b353b027bc532ca74b3610dac37
languageName: node
linkType: hard

"react-is@npm:^16.13.1":
version: 16.13.1
resolution: "react-is@npm:16.13.1"
Expand Down

0 comments on commit 13d2bb6

Please sign in to comment.