Skip to content

audit: deserialize proof with validation checks #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
manishbista28 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

audit: deserialize proof with validation checks #34

manishbista28 wants to merge 4 commits into from

Conversation

@manishbista28
Copy link
Contributor

@manishbista28 manishbista28 commented Dec 15, 2025 •
edited
Loading

@manishbista28 manishbista28 self-assigned this Dec 15, 2025
@manishbista28 manishbista28 marked this pull request as ready for review December 15, 2025 11:38
@manishbista28 manishbista28 mentioned this pull request Dec 16, 2025
Closed
This was referenced Dec 16, 2025
Open
Open
Open
@manishbista28 manishbista28 changed the title fix(proof): deserialize proof with validation checks audit: deserialize proof with validation checks Dec 17, 2025
@manishbista28
Copy link
Contributor Author

manishbista28 commented Dec 17, 2025

Also fixes #18
groth16_verify_compressed uses byte array which are deserialized to concrete types only later in circuit

@AaronFeickert AaronFeickert linked an issue Dec 19, 2025 that may be closed by this pull request
fix(gadget): input values to wires should not assume concrete type beforehand #18
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@manishbista28 manishbista28

Labels

audit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix(gadget): input values to wires should not assume concrete type beforehand audit: deserialize proof with validation checks

2 participants

@manishbista28