Skip to content

[Zellic] 8 The is_empty methods always return false #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manishbista28 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Zellic] 8 The is_empty methods always return false #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion g16ckt/src/gadgets/bn254/fq12.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ impl Fq12 {
}

pub fn is_empty(&self) -> bool {
self.0.is_empty()
self.len() == 0
}

pub fn new_constant(v: ark_bn254::Fq12) -> Fq12 {
Expand Down
2 changes: 1 addition & 1 deletion g16ckt/src/gadgets/bn254/fq2.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ impl Fq2 {
}

pub fn is_empty(&self) -> bool {
self.0.is_empty()
self.len() == 0
}

pub fn iter(&self) -> impl Iterator<Item = &WireId> {
Expand Down
2 changes: 1 addition & 1 deletion g16ckt/src/gadgets/bn254/fq6.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,7 @@ impl Fq6 {
}

pub fn is_empty(&self) -> bool {
self.0.is_empty()
self.len() == 0
}
}

Expand Down
Loading