Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated FAQ.md. #2937

Merged
merged 4 commits into from
Jan 7, 2025
Merged

Updated FAQ.md. #2937

merged 4 commits into from
Jan 7, 2025

Conversation

sr-dash
Copy link
Contributor

@sr-dash sr-dash commented Jan 3, 2025

Added documentation for Google Search Console ID creation and usage in the template for google-site-verification.

Added Google Search Console ID creation and usage in the template for google-site-verification.
Added documentation for Google Search Console ID generation ad usage in the template with `google-site-verification` tag.
Copy link

netlify bot commented Jan 3, 2025

Deploy Preview for relaxed-lollipop-b6bc17 ready!

Name Link
🔨 Latest commit 516d22a
🔍 Latest deploy log https://app.netlify.com/sites/relaxed-lollipop-b6bc17/deploys/677d7acff7c56b0008b203b4
😎 Deploy Preview https://deploy-preview-2937--relaxed-lollipop-b6bc17.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@george-gca
Copy link
Collaborator

Just missing prettier fix and it is good 2 go.

@sr-dash
Copy link
Contributor Author

sr-dash commented Jan 7, 2025

Can you help me fix the Prettier issue here on my PR? What should I change ?

@george-gca
Copy link
Collaborator

The ideal way is for you to run locally, preferably using the devcontainer that already includes the needed extension, or manually.

But we also created a GitHub action that creates an html diff with the needed changes. Unfortunately the action fails to attach the diff here, but you can see it created in the failed action. Upload HTML diff step.

@sr-dash
Copy link
Contributor Author

sr-dash commented Jan 7, 2025

HTML Diff (1).zip
This is the HTML diff file.

@george-gca
Copy link
Collaborator

Yes, check its content, it shows the changes needed.

@sr-dash
Copy link
Contributor Author

sr-dash commented Jan 7, 2025

Thanks. I checked the file and fixed the file according to the suggestions. It was just a matter of few extra scapes. Hopefully this time it will succeed in the workflow.

@george-gca george-gca merged commit 1da2e64 into alshedivat:main Jan 7, 2025
9 checks passed
@george-gca
Copy link
Collaborator

Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants