Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resume custom reference link bug #2941

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Conversation

rickyyuan07
Copy link
Contributor

@rickyyuan07 rickyyuan07 commented Jan 6, 2025

Hi,

I noticed an issue where the CV page fails to link to the correct custom PDF when the {% unless site.data.resume %} block is executed in cv.liquid. To resolve this, I updated the code to align its logic with the else block to make it consistent.

Copy link

netlify bot commented Jan 6, 2025

Deploy Preview for relaxed-lollipop-b6bc17 ready!

Name Link
🔨 Latest commit 3cf7d40
🔍 Latest deploy log https://app.netlify.com/sites/relaxed-lollipop-b6bc17/deploys/67867509b7306c000874c5c8
😎 Deploy Preview https://deploy-preview-2941--relaxed-lollipop-b6bc17.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rickyyuan07 rickyyuan07 changed the title ix resume custom reference bug Fix resume custom reference bug Jan 6, 2025
@rickyyuan07 rickyyuan07 changed the title Fix resume custom reference bug Fix resume custom reference link bug Jan 6, 2025
@george-gca george-gca merged commit c2cc214 into alshedivat:main Jan 14, 2025
10 checks passed
@george-gca
Copy link
Collaborator

Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants