fix(assistant): hide the change number when a reply proposes a single edit - #19
Open
amal66 wants to merge 5 commits into
Open
fix(assistant): hide the change number when a reply proposes a single edit#19amal66 wants to merge 5 commits into
amal66 wants to merge 5 commits into
Conversation
amal66
force-pushed
the
feat/tabular-editdetails
branch
5 times, most recently
from
July 6, 2026 00:26
0922ac4 to
0778c66
Compare
amal66
force-pushed
the
feat/tabular-editdetails
branch
from
July 10, 2026 02:56
0778c66 to
1e21622
Compare
EditCard already accepts `changeNumber` and AssistantMessage already assigns a running 1-based index, but the index was passed unconditionally, so a reply with a single proposed edit rendered a lone grey "1" above the card. Restores the suppression from 2bccd17, which was dropped when this branch was rebased onto the upstream sync: the commit's other hunks had already landed in main, so git resolved it to empty and discarded it, taking this behaviour with it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
amal66
changed the title
…tly ate The `changeNumber` suppression this branch restores had no test, which is why rebasing onto the upstream sync could resolve commit 2bccd17 to empty, drop it, and leave the branch with no diff — GitHub then auto-closed the PR and nobody noticed the behaviour had gone. The tree still compiled. Asserts the caller's logic, not just EditCard's prop: a lone edit renders no number, several edits number 1..n, and the counter runs across documents rather than restarting per document. Checked against main (which lacks the fix): the single-edit case fails there with `expected [ '1' ] to deeply equal []`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hides the change number when an assistant reply proposes exactly one edit — a lone "1" above the only card is noise — while retaining continuous 1-based numbering across multiple edits and multiple documents.
Why the PR is small
The EditCard redesign already landed independently on
main; this branch carries only the single-edit numbering behavior and its focused regression tests.Verification
AssistantMessage.test.tsx): single-edit omission, 1..n numbering, cross-document continuity, one card per proposed edit.main(olp UI sync, b3166dd): clean merge, no conflicts; the EditCardchangeNumberprop this PR relies on is unchanged on main.🤖 Generated with Claude Code
https://claude.ai/code/session_01CEguyEgXa9JjCciXCcVemC