fix(mac): stabilize Tailscale status timeout - #707
Merged
Conversation
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
🔍 Code Quality ReportThis comment is automatically updated with linting results from CI. Node.js Biome Formatting ✅ Status: PassedNode.js Biome Linting ✅ Status: PassedNode.js TypeScript Type Checking ✅ Status: PassedNode.js Build ✅ Status: PassedNode.js Tests ✅ Status: PassedNode.js Security Audit ✅ Status: PassedNode.js Test Coverage ✅ Status: PassedClient Coverage: Server Coverage: Mac Formatting (SwiftFormat) ✅ Status: PassedMac Linting (SwiftLint) ✅ Status: Passed |
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #706
Root cause
fetchStatusblocked a detached task while waiting for process output, then scheduled timeout enforcement on another Swift concurrency task. Under the heavily parallel Release test suite, executor saturation could delay that timeout task beyond the test's bound. The fixture's busy loop increased the same contention.Proof
Test Release Configurationcommand passed on commit1b9caddcf0a650630b581c97f470359914299f77with code coverage enabled.TailscaleCLITests.statusCommandTimesOutcompleted in 0.242 seconds within the full parallel Release suite.Risk
Low. The change preserves the existing timeout, TERM, and SIGKILL behavior while moving only timeout scheduling off the cooperative executor.