This repository was archived by the owner on Jun 19, 2020. It is now read-only.
Fixing name of the emptyDir created for the envoy config #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
I was able to verify that the helm chart option to enable the Datadog tracer works well (for 0.2.0)
But this commit is missing out on one modification.
Using 0.3.0 or 0.4.0 of the injector will not work if the Datadog tracer is enabled (the Volume and the VolumeMount have different names, so the pod never starts if is mutated by the injector).
Description of changes:
@stefanprodan - Apologies for the very long delay in testing the helm change, and thank you very much for doing it a few months back.
I made an image that cherry-picks this change off of master:
charlyyfon/appmesh:injector-0.4.1By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.